summaryrefslogtreecommitdiff
path: root/app
AgeCommit message (Collapse)Author
2019-03-29app/testpmd: display/clear forwarding stats on demandDavid Marchand
Add a new "show/clear fwd stats all" command to display fwd and port statistics on the fly. To be able to do so, the (testpmd only) rte_port structure can't be used to maintain any statistics. Moved the stats dump parts from stop_packet_forwarding() and merge with fwd_port_stats_display() into fwd_stats_display(). fwd engine statistics are then aggregated into a local per port array. Signed-off-by: David Marchand <david.marchand@redhat.com> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
2019-03-29app/testpmd: remove useless casts on statisticsDavid Marchand
Caught by code review while investigating the fwd stats display code. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
2019-03-29app/testpmd: extend forwarding statistics to 64 bitsDavid Marchand
fwd engine statistics are stored as unsigned int (32bits) and can wrap quite quickly. Example: sending 7mpps for 614s gives us 4298000000 packets => 0x1002e4680 larger than 32bits. testpmd reports forwarding stats as: RX-packets: 3500381 TX-packets: 3500010 TX-dropped: 371 While the port and accumulated stats are reported as 64bits: RX-packets: 4298467677 RX-dropped: 0 RX-total: 4298467677 TX-packets: 4298467306 TX-dropped: 371 TX-total: 4298467677 Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
2019-03-29app/testpmd: add missing newline when showing statisticsDavid Marchand
Having the standard stats and the rx burst stats on the same line gives a really long line and is not consistent with the rest. Before: iofwd engine RX-packets: 121811360 TX-packets: 121811392 TX-dropped: 0 RX-bursts : 3806605 [100% of 32 pkts] TX-bursts : 3806606 [100% of 32 pkts] csum engine RX-packets: 5467488 TX-packets: 5467520 TX-dropped: 0 RX- bad IP checksum: 0 Rx- bad L4 checksum: 0 Rx- bad outer L4 checksum: 0 RX-bursts : 170859 [100% of 32 pkts] TX-bursts : 170860 [100% of 32 pkts] After: iofwd engine RX-packets: 259770560 TX-packets: 259770592 TX-dropped: 0 RX-bursts : 8117830 [100% of 32 pkts] TX-bursts : 8117831 [100% of 32 pkts] csum engine RX-packets: 7834016 TX-packets: 7834048 TX-dropped: 0 RX- bad IP checksum: 0 Rx- bad L4 checksum: 0 Rx- bad outer L4 checksum: 0 RX-bursts : 244813 [100% of 32 pkts] TX-bursts : 244814 [100% of 32 pkts] Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
2019-03-31app/test: fix build with musl libcNatanael Copa
Fix following build error with musl libc: app/test/test_eal_flags.c:152:55: error: 'O_RDONLY' undeclared (first use in this function) fd = openat(dirfd(hugepage_dir), dirent->d_name, O_RDONLY); ^~~~~~~~ Fixes: 45f1b6e8680a ("app: add new tests on eal flags") Cc: stable@dpdk.org Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
2019-03-31app/test: fix flags with mesonNatanael Copa
in app/test/meson.build the default_cflag is never used so the -D_GNU_SOURCE was never passed as intended. Fixes the following build error with musl libc: lib/librte_eal/common/include/rte_lcore.h:26:9: error: unknown type name 'cpu_set_t' typedef cpu_set_t rte_cpuset_t; ^~~~~~~~~ The problem is that cpu_set_t is only defined when _GNU_SOURCE is set. Fixes: 5d7b673d5fd6 ("mk: build with _GNU_SOURCE defined by default") Cc: stable@dpdk.org Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
2019-03-28fbarray: add API to find biggest used or free chunksAnatoly Burakov
Currently, while there is a way to find total amount of used/free space in an fbarray, there is no way to find biggest contiguous chunk. Add such API, as well as unit tests to test this API. Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
2019-03-28service: fix parameter type for attributeNikhil Rao
The type of value parameter to rte_service_attr_get should be uint64_t *, since the attributes are of type uint64_t. Fixes: 4d55194d76a4 ("service: add attribute get function") Signed-off-by: Nikhil Rao <nikhil.rao@intel.com> Reviewed-by: Gage Eads <gage.eads@intel.com> Reviewed-by: Rami Rosen <ramirose@gmail.com> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
2019-03-28test/timer: replace config macro with runtime log levelDharmik Thakkar
This patch replaces macro with log-level based approach to print debug information. Need to set timer log type to debug using the following eal parameter: --log-level=test.timer:debug Suggested-by: Thomas Monjalon <thomas@monjalon.net> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> Reviewed-by: Gavin Hu <gavin.hu@arm.com> Reviewed-by: Phil Yang <phil.yang@arm.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
2019-03-28test/efd: replace config macro with runtime log levelDharmik Thakkar
This patch enables compilation of print_key_info() always using log-level based approach instead of a macro. Need to set efd log type to debug to print debug information, using the following eal parameter: --log-level=test.efd:debug Suggested-by: Thomas Monjalon <thomas@monjalon.net> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> Reviewed-by: Gavin Hu <gavin.hu@arm.com> Reviewed-by: Phil Yang <phil.yang@arm.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
2019-03-28test/hash: replace config macro with runtime log levelDharmik Thakkar
Need to set hash log type to debug to print debug information, using following eal parameter: --log-level=test.hash:debug Suggested-by: Thomas Monjalon <thomas@monjalon.net> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> Reviewed-by: Gavin Hu <gavin.hu@arm.com> Reviewed-by: Phil Yang <phil.yang@arm.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
2019-03-28test/ticketlock: add test casesJoyce Kong
Add test cases for ticket lock, recursive ticket lock, and ticket lock performance. Signed-off-by: Joyce Kong <joyce.kong@arm.com> Reviewed-by: Gavin Hu <gavin.hu@arm.com> Reviewed-by: Phil Yang <phil.yang@arm.com> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
2019-03-28test/rwlock: amortize the cost of getting timeJoyce Kong
Instead of getting timestamp per iteration, amortize its overhead can help to get more precise benchmarking results. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Joyce Kong <joyce.kong@arm.com> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
2019-03-28test/rwlock: benchmark on all available coresJoyce Kong
Add performance test on all available cores to benchmark the scaling up performance of rw_lock. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Suggested-by: Gavin Hu <gavin.hu@arm.com> Signed-off-by: Joyce Kong <joyce.kong@arm.com> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
2019-03-28test/spinlock: amortize the cost of getting timeGavin Hu
Instead of getting timestamps per iteration, amortize its overhead can help getting more precise benchmarking results. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Gavin Hu <gavin.hu@arm.com> Reviewed-by: Joyce Kong <joyce.kong@arm.com> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> Acked-by: Nipun Gupta <nipun.gupta@nxp.com> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
2019-03-28test/spinlock: remove delay for correct benchmarkingGavin Hu
The test is to benchmark the performance of spinlock by counting the number of spinlock acquire and release operations within the specified time. A typical pair of lock and unlock operations costs tens or hundreds of nano seconds, in comparison to this, delaying 1 us outside of the locked region is too much, compromising the goal of benchmarking the lock and unlock performance. Fixes: af75078fece3 ("first public release") Cc: stable@dpdk.org Signed-off-by: Gavin Hu <gavin.hu@arm.com> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> Reviewed-by: Joyce Kong <joyce.kong@arm.com> Reviewed-by: Phil Yang <phil.yang@arm.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> Reviewed-by: Ola Liljedahl <ola.liljedahl@arm.com> Acked-by: Jerin Jacob <jerinj@marvell.com> Acked-by: Nipun Gupta <nipun.gupta@nxp.com> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
2019-03-28eal: add macro to align value to the nearest multiplePavan Nikhilesh
Add macro to align value to the nearest multiple of the given value, resultant value might be greater than or less than the first parameter whichever difference is the lowest. Update unit test to include the new macro. Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
2019-03-27use appropriate EAL macro for constructorsJerin Jacob
Use eal's RTE_INIT abstraction for defining constructors. Signed-off-by: Jerin Jacob <jerinj@marvell.com> Reviewed-by: David Marchand <david.marchand@redhat.com>
2019-03-27test: fix build without pdumpReshma Pattan
pdump unit test has dependency on pthread code in test.c and process.h to run send_pkts(), this code should be enabled only when CONFIG_RTE_LIBRTE_PDUMP is enabled. Bugzilla ID: 222 Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library") Cc: stable@dpdk.org Signed-off-by: Reshma Pattan <reshma.pattan@intel.com> Reviewed-by: Rami Rosen <ramirose@gmail.com>
2019-03-27app/pipeline: fix dependency for FreeBSDBruce Richardson
When building on FreeBSD, the compiler emitted an error due to being unable to find rte_pci.h. This was due to missing dependencies for the application. Fixes: 474572d2ae5a ("app/pipeline: move from test directory") Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
2019-03-22test/crypto: add tests for XTS on QATDamian Nowak
This patch adds test vectors for AES XTS mode on QAT. It uses different plaintext sizes and AES keys sizes of 128 and 256 bits. Signed-off-by: Damian Nowak <damianx.nowak@intel.com> Acked-by: Fiona Trahe <fiona.trahe@intel.com> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
2019-03-22test/crypto: fix possible overflow using strlcatChaitanya Babu Talluri
strcat does not check the destination length and there might be chances of string overflow so instead of strcat, strlcat is used. Fixes: 6f4eec2565 ("test/crypto: enhance scheduler unit tests") Cc: stable@dpdk.org Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
2019-03-22test: add result field to mod exp and invArek Kusztal
This patch adds result field to modular exponentiation and modular multiplicative inverse tests Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com> Acked-by: Shally Verma <shallyv@marvell.com>
2019-03-20app/testpmd: fix stdout flush after printing statsIgor Romanov
User can specify stats period(n). The statistics should be available to user every n second. But the print_stats() function does not force stdout to be flushed, so for instance, a user reading testpmd's stdout through pipe will not be able to read it until the stdout buffer is filled. Fixes: cfea1f3048d1 ("app/testpmd: print statistics periodically") Cc: stable@dpdk.org Signed-off-by: Igor Romanov <igor.romanov@oktetlabs.ru> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
2019-03-20app/testpmd: fix a typo in log messageRami Rosen
This patch fixes a typo in test-pmd/cmdline.c, succcessfully->successfully Two C's are good enough for success... Fixes: a09f3e4c5046 ("app/testpmd: add hash configuration") Cc: stable@dpdk.org Signed-off-by: Rami Rosen <ramirose@gmail.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
2019-03-20app/testpmd: remove unused field from port structDavid Marchand
Remove some leftover from a previous rework. Fixes: c4bcc342c8ee ("app/testpmd: refactor ieee1588 forwarding") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com> Reviewed-by: Rami Rosen <ramirose@gmail.com>
2019-03-20app/testpmd: optimize MAC swap for ArmRuifeng Wang
Improved MAC swap performance for ARM platform. The improvement was achieved by using neon intrinsics to save CPU cycles and doing swap for four packets at a time. The optimization had 15% - 20% throughput boost in testpmd MAC swap mode. Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com> Reviewed-by: Gavin Hu <gavin.hu@arm.com> Reviewed-by: Phil Yang <phil.yang@arm.com> Acked-by: Jerin Jacob <jerinj@marvell.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
2019-03-23malloc: add NUMA-aware realloc functionTomasz Jozwiak
Currently, rte_realloc will not respect original allocation's NUMA node when memory cannot be resized, and there is no NUMA-aware equivalent of rte_realloc. This patch adds such a function. The new API will ensure that reallocated memory stays on requested NUMA node, as well as allow moving allocated memory to a different NUMA node. Signed-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
2019-03-15app/eventdev: start event producers after eventdevPavan Nikhilesh
Start event producers after eventdev i.e. consumer is started as in some architectures it might lead to undefined behaviour or events being dropped. Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> Reviewed-by: Jerin Jacob <jerinj@marvell.com>
2019-03-15app/eventdev: configure optimum timers per adapterPavan Nikhilesh
Previously, the total number of event timers per adapter was set to an arbitrary value, set it to mempool size instead as it defines the max event timers that can be armed. Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> Acked-by: Jerin Jacob <jerinj@marvell.com>
2019-03-15app/eventdev: follow proper teardown sequencePavan Nikhilesh
Stop eventdev before closing it. Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
2019-03-12mk: use linux and freebsd in config namesBruce Richardson
Rather than using linuxapp and bsdapp everywhere, we can change things to use the, more readable, terms "linux" and "freebsd" in our build configs. Rather than renaming the configs we can just duplicate the existing ones with the new names using symlinks, and use the new names exclusively internally. ["make showconfigs" also only shows the new names to keep the list short] The result is that backward compatibility is kept fully but any new builds or development can be done using the newer names, i.e. both "make config T=x86_64-native-linuxapp-gcc" and "T=x86_64-native-linux-gcc" work. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
2019-03-12build/freebsd: rename macro BSDPAPP to FREEBSDBruce Richardson
Rename the macro and all instances in DPDK code, but keep a copy of the old macro defined for legacy code linking against DPDK Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
2019-03-12build/linux: rename macro from LINUXAPP to LINUXBruce Richardson
Rename the macro to make things shorter and more comprehensible. For both meson and make builds, keep the old macro around for backward compatibility. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
2019-03-06test/crypto: fix duplicate id used by CCP deviceHemant Agrawal
These duplicate device id is causing incorrect mapping for DPAA_SEC for test case execution on the basis of capabilities. Fixes: e155ca055e84 ("test/crypto: add tests for AMD CCP") Cc: stable@dpdk.org Reported-by: Anoob Joseph <anoobj@marvell.com> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
2019-03-01app/pdump: remove only created vdevsGage Eads
This commit fixes a bug in which a unidirectional pdump could attempt to remove devices it didn't create. Fixes: 35cb223ab7be ("app/pdump: fix vdev cleanup") Cc: stable@dpdk.org Signed-off-by: Gage Eads <gage.eads@intel.com> Acked-by: Reshma Pattan <reshma.pattan@intel.com>
2019-03-01app/compress-perf: call generic strlcpyThomas Monjalon
The call to strlcpy uses either libc, libbsd or internal rte_strlcpy. No need to call the DPDK flavor explicitly. Signed-off-by: Thomas Monjalon <thomas@monjalon.net> Reviewed-by: Rami Rosen <ramirose@gmail.com>
2019-02-26test/compress: fix missing header includeBruce Richardson
usleep() is defined in unistd.h, which is missing from include list in test_compressdev.c, causing compiler errors on FreeBSD. Fixes: b06aa643cac4 ("test/compress: add initial unit tests") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
2019-02-26test: move to app directoryBruce Richardson
Since all other apps have been moved to the "app" folder, the autotest app remains alone in the test folder. Rather than having an entire top-level folder for this, we can move it back to where it all started in early versions of DPDK - the "app/" folder. This move has a couple of advantages: * This reduces clutter at the top level of the project, due to one less folder. * It eliminates the separate build task necessary for building the autotests using make "make test-build" which means that developers are less likely to miss something in their own compilation tests * It re-aligns the final location of the test binary in the app folder when building with make with it's location in the source tree. For meson builds, the autotest app is different from the other apps in that it needs a series of different test cases defined for it for use by "meson test". Therefore, it does not get built as part of the main loop in the app folder, but gets built separately at the end. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
2019-02-26app/pipeline: move from test directoryBruce Richardson
Move to the app directory, and add to meson build. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
2019-02-26app/acl: move from test directoryBruce Richardson
Move to "app" directory and enable with meson build. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
2019-02-26app/cmdline: move from test directoryBruce Richardson
Move app to "app" directory and enable with meson build. For consistency of naming, the subdirectory is also renamed from cmdline_test to test-cmdline. Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
2019-02-07app/testpmd: add TOS and TTL fields to VXLAN encapsulationViacheslav Ovsiienko
The new testpmd set vxlan-tos-ttl command is added. It allows to specify tos and tll fields for encapsulation IP header. IPv4 VXLAN outer header: testpmd> set vxlan-tos-ttl ip-version ipv4 vni 4 udp-src 4 udp-dst 4 ip-tos 0 ip-ttl 255 ip-src 127.0.0.1 ip-dst 128.0.0.1 eth-src 11:11:11:11:11:11 eth-dst 22:22:22:22:22:22 IPv6 VXLAN outer header: testpmd> set vxlan-tos-ttl ip-version ipv6 vni 4 udp-src 4 udp-dst 4 ip-tos 0 ip-ttl 255 ::1 ip-dst ::2222 eth-src 11:11:11:11:11:11 eth-dst 22:22:22:22:22:22 Note: ip-ttl parameter corresponds the nop_limits field for IPv6. Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com> Acked-by: Ori Kam <orika@mellanox.com>
2019-01-24app/testpmd: fix Tx metadata show commandDekel Peled
Function cmd_config_tx_metadata_specific_parsed() takes input value, applies rte_cpu_to_be_32() on it, and stores it for Tx use. Function cmd_show_tx_metadata_parsed() displays the stored value as is. This patch modifies function cmd_show_tx_metadata_parsed(), to apply rte_be_to_cpu_32() on the stored value before displaying it. Fixes: c18feafa193c ("app/testpmd: support metadata as flow rule item") Cc: stable@dpdk.org Signed-off-by: Dekel Peled <dekelp@mellanox.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
2019-01-17app/pdump: fix vdev cleanupReshma Pattan
Virtual devices added in pdump application using rte_eal_hotplug_add should be removed explicitly while exiting the pdump application, otherwise the subsequent run of the pdump application will fail with the reason that virtual devices with the same name already exists in primary. Fixes: 6362f362a2 ("app/pdump: use EAL hotplug instead of ethdev attach") Cc: stable@dpdk.org Signed-off-by: Reshma Pattan <reshma.pattan@intel.com> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
2019-01-15app/testpmd: check mbufs in verbose modeDavid Marchand
Let's check the received/sent mbufs, it can help debugging. Signed-off-by: David Marchand <david.marchand@redhat.com> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
2019-01-14app/testpmd: fix missing prefetch in macswap modeYongseok Koh
Prefetching packet was missing when do_macswap() was optimized. Fixes: 62b52877adbe ("app/testpmd: batch MAC swap for performance on x86") Signed-off-by: Yongseok Koh <yskoh@mellanox.com> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
2019-01-14app/testpmd: fix pointer reference in macswapYongseok Koh
The pointer is misused and could set wrong MAC address. As a result, some of packets can be dropped in receiver side due to MAC address mismatch. This can be shown as performance degradation. Bugzilla ID: 188 Fixes: 62b52877adbe ("app/testpmd: batch MAC swap for performance on x86") Signed-off-by: Yongseok Koh <yskoh@mellanox.com> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
2019-01-14app/testpmd: fix quit to stop all ports before closeCristian Dumitrescu
This patch proposes a slightly different test-pmd quit operation: stop all devices before starting to close any device. Basically, stop all moving parts before beginning to remove them. The current test-pmd quit is stopping and closing each device before moving to the next device. If all devices in the system are independent of each other, this difference is usually not important. In case of Soft NIC devices, any such virtual device typically depends on one or more physical devices being alive, as it accesses their queues, so this difference becomes important. Without this straightforward fix, all the Soft NIC devices need to be manually stopped before the quit command is issued, otherwise the quit command can sometimes crash the test-pmd application. Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and SIGTERM") Cc: stable@dpdk.org Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
2019-01-10app/bbdev: fix return value checkAmr Mokhtar
Added assert check for rte_bbdev_*_op_alloc_bulk in bbdev test app Coverity issue: 328516, 328525 Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: stable@dpdk.org Signed-off-by: Amr Mokhtar <amr.mokhtar@intel.com>