summaryrefslogtreecommitdiff
path: root/usertools
diff options
context:
space:
mode:
authorGuduri Prathyusha <gprathyusha@caviumnetworks.com>2017-04-26 19:22:19 +0530
committerThomas Monjalon <thomas@monjalon.net>2017-04-30 15:28:01 +0200
commit720b7a058260dfd6ae0fcce956bfe44c18681499 (patch)
treeb257d447cc4500e2c302da19d99aeb80a483d558 /usertools
parentaafaea3d3b703ce052b7034f7542443cc2d06e32 (diff)
downloaddpdk-next-eventdev-720b7a058260dfd6ae0fcce956bfe44c18681499.zip
dpdk-next-eventdev-720b7a058260dfd6ae0fcce956bfe44c18681499.tar.gz
dpdk-next-eventdev-720b7a058260dfd6ae0fcce956bfe44c18681499.tar.xz
usertools: fix device binding with kernel tools
The following sequence of operation gives error in binding devices 1) Bind a device using dpdk-devbind.py 2) Unbind the device using kernel tools(/sys/bus/pci/device/driver/unbind) 3) Bind the device using kernel tools(/sys/bus/pci/driver/new_id and /sys/bus/pci/driver/bind) The bind failure was due to cached driver name in 'driver_override'. Fix it by writing 'null' to driver_override just after binding a device so that any method of binding/unbinding can be used. Fixes: 2fc350293570 ("usertools: use optimized driver override scheme to bind") Reported-by: Lijuan A Tu <lijuanx.a.tu@intel.com> Signed-off-by: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
Diffstat (limited to 'usertools')
-rwxr-xr-xusertools/dpdk-devbind.py38
1 files changed, 19 insertions, 19 deletions
diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index bb4d536..1dc1065 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -386,25 +386,6 @@ def unbind_one(dev_id, force):
"Skipping unbind" % (dev_id))
return
- # For kernels > 3.15 driver_override is used to bind a device to a driver.
- # Before unbinding it, overwrite driver_override with empty string so that
- # the device can be bound to any other driver
- filename = "/sys/bus/pci/devices/%s/driver_override" % dev_id
- if os.path.exists(filename):
- try:
- f = open(filename, "w")
- except:
- print("Error: unbind failed for %s - Cannot open %s"
- % (dev_id, filename))
- sys.exit(1)
- try:
- f.write("\00")
- f.close()
- except:
- print("Error: unbind failed for %s - Cannot open %s"
- % (dev_id, filename))
- sys.exit(1)
-
# write to /sys to unbind
filename = "/sys/bus/pci/drivers/%s/unbind" % dev["Driver_str"]
try:
@@ -507,6 +488,25 @@ def bind_one(dev_id, driver, force):
bind_one(dev_id, saved_driver, force)
return
+ # For kernels > 3.15 driver_override is used to bind a device to a driver.
+ # Before unbinding it, overwrite driver_override with empty string so that
+ # the device can be bound to any other driver
+ filename = "/sys/bus/pci/devices/%s/driver_override" % dev_id
+ if os.path.exists(filename):
+ try:
+ f = open(filename, "w")
+ except:
+ print("Error: unbind failed for %s - Cannot open %s"
+ % (dev_id, filename))
+ sys.exit(1)
+ try:
+ f.write("\00")
+ f.close()
+ except:
+ print("Error: unbind failed for %s - Cannot open %s"
+ % (dev_id, filename))
+ sys.exit(1)
+
def unbind_all(dev_list, force=False):
"""Unbind method, takes a list of device locations"""