summaryrefslogtreecommitdiff
path: root/devtools
diff options
context:
space:
mode:
authorArnon Warshavsky <arnon@qwilt.com>2018-12-18 17:19:00 +0200
committerThomas Monjalon <thomas@monjalon.net>2018-12-21 01:58:23 +0100
commitdafc04c15174e84ca04a7f4ebe67b10c059a5c0c (patch)
treecf66028fc5a91bb926a3fb4953eb1d1175d5033e /devtools
parentd5c677db89cc1e6113d55d8bf2300ec8b5f2d383 (diff)
downloaddpdk-next-eventdev-dafc04c15174e84ca04a7f4ebe67b10c059a5c0c.zip
dpdk-next-eventdev-dafc04c15174e84ca04a7f4ebe67b10c059a5c0c.tar.gz
dpdk-next-eventdev-dafc04c15174e84ca04a7f4ebe67b10c059a5c0c.tar.xz
devtools: fix return of forbidden addition checks
Explicitly collect the error code of the multiple awk script calls. Bugzilla ID: 165 Fixes: 4d4c612e6a30 ("devtools: check wrong svg include in guides") Cc: stable@dpdk.org Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>
Diffstat (limited to 'devtools')
-rwxr-xr-xdevtools/checkpatches.sh9
1 files changed, 7 insertions, 2 deletions
diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index ee8debe..3b03b7e 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -44,6 +44,8 @@ print_usage () {
}
check_forbidden_additions() { # <patch>
+ res=0
+
# refrain from new additions of rte_panic() and rte_exit()
# multiple folders and expressions are separated by spaces
awk -v FOLDERS="lib drivers" \
@@ -51,7 +53,8 @@ check_forbidden_additions() { # <patch>
-v RET_ON_FAIL=1 \
-v MESSAGE='Using rte_panic/rte_exit' \
-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
- "$1"
+ "$1" || res=1
+
# svg figures must be included with wildcard extension
# because of png conversion for pdf docs
awk -v FOLDERS='doc' \
@@ -59,7 +62,9 @@ check_forbidden_additions() { # <patch>
-v RET_ON_FAIL=1 \
-v MESSAGE='Using explicit .svg extension instead of .*' \
-f $(dirname $(readlink -e $0))/check-forbidden-tokens.awk \
- "$1"
+ "$1" || res = 1
+
+ return $res
}
number=0