path: root/devtools
diff options
authorNeil Horman <>2018-11-01 09:54:10 -0400
committerThomas Monjalon <>2018-11-18 23:38:26 +0100
commit5a5f4676eb93fa410b56df060a6d0c7603469f81 (patch)
tree735be3439eaf5215b38349d68ba7133fdcde166a /devtools
parentbc44d448479846966f7aedb90fefe2fa5bd20d2e (diff)
devtools: fix regex in symbol addition check
The regex to determine the end of the map file chunk in a patch seems to be wrong, It was using perl regex syntax, which awk doesn't appear to support (I'm still not sure how it was working previously). Regardless, it wasn't triggering and as a result symbols were getting added to the mapdb that shouldn't be there. Fix it by converting the regex to use traditional posix syntax, matching only on the negation of the character class [^map] Tested and shown to be working on the ip_frag patch set provided by Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") Cc: Reported-by: Cody Doucette <> Signed-off-by: Neil Horman <>
Diffstat (limited to 'devtools')
1 files changed, 1 insertions, 2 deletions
diff --git a/devtools/ b/devtools/
index c0d2a6d..1d21e91 100755
--- a/devtools/
+++ b/devtools/
@@ -23,7 +23,7 @@ build_map_changes()
# does not end in 'map', indicating we have left the map chunk.
# When we hit this, turn off the in_map variable, which
# supresses the subordonate rules below
- /[-+] a\/.*\.^(map)/ {in_map=0}
+ /[-+] a\/.*\.[^map]/ {in_map=0}
# Triggering this rule, which starts a line and ends it
# with a { identifies a versioned section. The section name is
@@ -153,7 +153,6 @@ clean_and_exit_on_sig()
build_map_changes "$patch" "$mapfile"
check_for_rule_violations "$mapfile"
rm -f "$mapfile"
exit $exit_code