summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFerruh Yigit <ferruh.yigit@intel.com>2019-11-22 11:30:23 +0000
committerThomas Monjalon <thomas@monjalon.net>2019-11-25 23:51:52 +0100
commit6b01864cc9c59a731dbc727a96995fd2b2ff452f (patch)
tree9afb0c36955fddefffb662acfee77f1bd4d89cd7
parent39a19ae03d8fe6210f3e7919b29378bd3223621c (diff)
downloaddpdk-next-eventdev-6b01864cc9c59a731dbc727a96995fd2b2ff452f.zip
dpdk-next-eventdev-6b01864cc9c59a731dbc727a96995fd2b2ff452f.tar.gz
dpdk-next-eventdev-6b01864cc9c59a731dbc727a96995fd2b2ff452f.tar.xz
mk: remove library search path from binary
This patch functionally reverts the patch in fixes line to not have any hardcoded library path in the final binary for the security reasons, in case this binary distributed to production environment. RPATH only added in RTE_DEVEL_BUILD case and this binary shouldn't distributed, but still removing it to be cautious. Fixes: 8919f73bcbaa ("mk: add build directory to library search path") Cc: stable@dpdk.org Suggested-by: Bruce Richardson <bruce.richardson@intel.com> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
-rwxr-xr-xdevtools/test-null.sh2
-rw-r--r--mk/rte.app.mk4
2 files changed, 2 insertions, 4 deletions
diff --git a/devtools/test-null.sh b/devtools/test-null.sh
index d82c6ad..72aa82b 100755
--- a/devtools/test-null.sh
+++ b/devtools/test-null.sh
@@ -11,6 +11,7 @@ coremask=${2:-3} # default using cores 0 and 1
eal_options=$3
testpmd_options=$4
+[ -f "$testpmd" ] && build=$(dirname $(dirname $testpmd))
[ -f "$testpmd" ] || testpmd=$build/app/dpdk-testpmd
[ -f "$testpmd" ] || testpmd=$build/app/testpmd
if [ ! -f "$testpmd" ] ; then
@@ -19,6 +20,7 @@ if [ ! -f "$testpmd" ] ; then
fi
if ldd $testpmd | grep -q librte_ ; then
+ export LD_LIBRARY_PATH=$build/lib:$LD_LIBRARY_PATH
libs='-d librte_mempool_ring.so -d librte_pmd_null.so'
else
libs=
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index a278552..05ea034 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -379,10 +379,6 @@ filter-libs = \
LDLIBS := $(call filter-libs,$(LDLIBS))
-ifeq ($(RTE_DEVEL_BUILD)$(CONFIG_RTE_BUILD_SHARED_LIB),yy)
-LDFLAGS += -rpath=$(RTE_SDK_BIN)/lib
-endif
-
MAPFLAGS = -Map=$@.map --cref
.PHONY: all