summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Ehrhardt <christian.ehrhardt@canonical.com>2019-08-29 17:30:03 +0200
committerThomas Monjalon <thomas@monjalon.net>2019-10-12 14:45:54 +0200
commit31b798a6f08e9b333b94b8bb26910209aa810b73 (patch)
tree653dbb17769362cc36208c3f00b07969a6c621e5
parent7fa2537226cd348dd0282630bc0db537a4897b29 (diff)
downloaddpdk-next-eventdev-31b798a6f08e9b333b94b8bb26910209aa810b73.zip
dpdk-next-eventdev-31b798a6f08e9b333b94b8bb26910209aa810b73.tar.gz
dpdk-next-eventdev-31b798a6f08e9b333b94b8bb26910209aa810b73.tar.xz
build: avoid overlinking
A while ago telemetry was added in 57ae0ec6 and it also added as-needed to config/meson.build. This seems no more needed these days as due to other build changes the ordering in buildlogs is: [...] -lrte_telemetry [...] -Wl,--no-as-needed [...] Which means telemetry no more benefits from --no-as-needed anyway. Overlinking problems get triggered by the meson generated pkgconfig which will have: [...] -Wl,--no-as-needed <somelibsusedbydpdk> This will overlink <somelibs> and in addition anything that follows as it also doesn't wrap back to --as-needed. So if a projects includes dpdk libs + <other> it will also consider <other> with --no-as-needed. Ubuntu bug: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1841759 Fixes: 57ae0ec62620 ("build: add dependency on telemetry to apps with meson") Cc: stable@dpdk.org Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> Acked-by: Luca Boccassi <bluca@debian.org>
-rw-r--r--config/meson.build1
1 files changed, 0 insertions, 1 deletions
diff --git a/config/meson.build b/config/meson.build
index 2bafea5..a27f731 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -94,7 +94,6 @@ dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper(), 1)
dpdk_conf.set('RTE_ARCH_64', cc.sizeof('void *') == 8)
add_project_link_arguments('-Wl,--no-as-needed', language: 'c')
-dpdk_extra_ldflags += '-Wl,--no-as-needed'
# use pthreads
add_project_link_arguments('-pthread', language: 'c')