summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Marchand <david.marchand@redhat.com>2019-05-03 16:34:20 +0200
committerThomas Monjalon <thomas@monjalon.net>2019-05-10 00:19:31 +0200
commitaf14b150df78ec46de919ae4a30efbefbcd44c95 (patch)
tree0d03e3489c6ee1f56a3a1e66445847d09b679f6e
parentd4ef40f3c60e0d8a93a86373f81beaba5731c58b (diff)
downloaddpdk-draft-windows-af14b150df78ec46de919ae4a30efbefbcd44c95.zip
dpdk-draft-windows-af14b150df78ec46de919ae4a30efbefbcd44c95.tar.gz
dpdk-draft-windows-af14b150df78ec46de919ae4a30efbefbcd44c95.tar.xz
devtools: fix check of symbol added as stable API
The incriminated commit broke the detection of new symbols skipping the EXPERIMENTAL step before entering a stable ABI section. sed won't return an error, check a null output instead. Fixes: 3630757803ab ("devtools: accept experimental symbol promotion") Cc: stable@dpdk.org Signed-off-by: David Marchand <david.marchand@redhat.com>
-rwxr-xr-xdevtools/check-symbol-change.sh25
1 files changed, 17 insertions, 8 deletions
diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh
index 28f093a..c5434f3 100755
--- a/devtools/check-symbol-change.sh
+++ b/devtools/check-symbol-change.sh
@@ -110,15 +110,24 @@ check_for_rule_violations()
# A symbol can not enter a non experimental
# section directly
- if [ $? -ne 0 ] && [ "$secname" != 'EXPERIMENTAL' ]
+ if [ -z "$oldsecname" ]
then
- echo -n "ERROR: symbol $symname "
- echo -n "is added in the $secname "
- echo -n "section, but is expected to "
- echo -n "be added in the EXPERIMENTAL "
- echo "section of the version map"
- ret=1
- continue
+ if [ "$secname" = 'EXPERIMENTAL' ]
+ then
+ echo -n "INFO: symbol $symname has "
+ echo -n "been added to the "
+ echo -n "EXPERIMENTAL section of the "
+ echo "version map"
+ continue
+ else
+ echo -n "ERROR: symbol $symname "
+ echo -n "is added in the $secname "
+ echo -n "section, but is expected to "
+ echo -n "be added in the EXPERIMENTAL "
+ echo "section of the version map"
+ ret=1
+ continue
+ fi
fi
# This symbol is moving inside a section, nothing to do