summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorYipeng Wang <yipeng1.wang@intel.com>2018-09-28 07:11:05 -0700
committerThomas Monjalon <thomas@monjalon.net>2018-10-25 23:58:12 +0200
commitb772a15eb84ce616114880a20ad6ad91bb8970fc (patch)
treed98deb241bdce96d310a66aaed2e3a120158d052 /test
parent636e5af0380e461895e666d41039c1acf877a08d (diff)
downloaddpdk-b772a15eb84ce616114880a20ad6ad91bb8970fc.zip
dpdk-b772a15eb84ce616114880a20ad6ad91bb8970fc.tar.gz
dpdk-b772a15eb84ce616114880a20ad6ad91bb8970fc.tar.xz
test/hash: fix bucket size in perf test
The bucket size was changed from 4 to 8 but the corresponding perf test was not changed accordingly. In the test, the bucket size and number of buckets are used to map to the underneath rte_hash structure. They are used to test performance of two conditions: keys in primary buckets only and keys in both primary and secondary buckets. Although there is no functional issue with bucket size set to 4, it mismatches the underneath rte_hash structure, which may affect code readability and future extension. Fixes: 58017c98ed53 ("hash: add vectorized comparison") Cc: stable@dpdk.org Signed-off-by: Yipeng Wang <yipeng1.wang@intel.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Diffstat (limited to 'test')
-rw-r--r--test/test/test_hash_perf.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c
index 33dcb9f..fe11632 100644
--- a/test/test/test_hash_perf.c
+++ b/test/test/test_hash_perf.c
@@ -20,7 +20,8 @@
#define MAX_ENTRIES (1 << 19)
#define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */
#define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added, several times */
-#define BUCKET_SIZE 4
+/* BUCKET_SIZE should be same as RTE_HASH_BUCKET_ENTRIES in rte_hash library */
+#define BUCKET_SIZE 8
#define NUM_BUCKETS (MAX_ENTRIES / BUCKET_SIZE)
#define MAX_KEYSIZE 64
#define NUM_KEYSIZES 10