summaryrefslogtreecommitdiff
path: root/examples/vhost_scsi
diff options
context:
space:
mode:
authorStefan Hajnoczi <stefanha@redhat.com>2018-01-31 17:48:28 +0000
committerFerruh Yigit <ferruh.yigit@intel.com>2018-02-05 15:18:56 +0100
commitd56f6320753585af304c296ff01d8401968fd7f4 (patch)
treedace29ad1b19f337564120382b99231c2c83d2a0 /examples/vhost_scsi
parent33adfbc805651f455dbf19f1e4b4b0878717a5e5 (diff)
downloaddpdk-d56f6320753585af304c296ff01d8401968fd7f4.zip
dpdk-d56f6320753585af304c296ff01d8401968fd7f4.tar.gz
dpdk-d56f6320753585af304c296ff01d8401968fd7f4.tar.xz
examples/vhost_scsi: drop unimplemented event index feature
The vhost_scsi example application negotiates the VIRTIO_RING_F_EVENT_IDX feature bit but does not honor it when accessing vrings. In particular, commit e37ff954405addb8ea422426a2d162d00dcad196 ("vhost: support virtqueue interrupt/notification suppression") broke vring call because vq->last_used_idx is never updated by vhost_scsi. The vq->last_used_idx field is not even available via the librte_vhost public API, so VIRTIO_RING_F_EVENT_IDX is currently only usable by the built-in virtio_net.c driver in librte_vhost. This patch drops VIRTIO_RING_F_EVENT_IDX from vhost_scsi so that vring call works again. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Changpeng Liu <changpeng.liu@intel.com> Acked-by: Yuanhan Liu <yliu@fridaylinux.org>
Diffstat (limited to 'examples/vhost_scsi')
-rw-r--r--examples/vhost_scsi/vhost_scsi.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/examples/vhost_scsi/vhost_scsi.c b/examples/vhost_scsi/vhost_scsi.c
index da01ad3..3cb4383 100644
--- a/examples/vhost_scsi/vhost_scsi.c
+++ b/examples/vhost_scsi/vhost_scsi.c
@@ -21,7 +21,6 @@
#include "scsi_spec.h"
#define VIRTIO_SCSI_FEATURES ((1 << VIRTIO_F_NOTIFY_ON_EMPTY) |\
- (1 << VIRTIO_RING_F_EVENT_IDX) |\
(1 << VIRTIO_SCSI_F_INOUT) |\
(1 << VIRTIO_SCSI_F_CHANGE))