summaryrefslogtreecommitdiff
path: root/drivers/net/mlx5/mlx5_stats.c
diff options
context:
space:
mode:
authorShahaf Shuler <shahafs@mellanox.com>2017-09-14 13:50:37 +0300
committerFerruh Yigit <ferruh.yigit@intel.com>2017-10-06 02:49:48 +0200
commit9f9a48eb2978157954242e08acf81d7a26f38810 (patch)
tree781dbdff4bf64dd387b54f8271b545e3c5707b9a /drivers/net/mlx5/mlx5_stats.c
parentf2fdd44cc1a162d9f6c3c866f0eaca71670bb953 (diff)
downloaddpdk-9f9a48eb2978157954242e08acf81d7a26f38810.zip
dpdk-9f9a48eb2978157954242e08acf81d7a26f38810.tar.gz
dpdk-9f9a48eb2978157954242e08acf81d7a26f38810.tar.xz
net/mlx5: fix Tx stats error counter definition
The current Tx error counter counts, according to its description, the total number of packets not sent when TX ring full. It is reported to application as part of oerrors field. The drop due to full ring is not the statistic that should be set on oerrors field. Such number can be counted by the application using the return value of the Tx burst function. The number that should be set there is the number of packets the device could not transmit in any way, even when it has resources. Therefore, replace this counter to count the total number of failed transmitted packets. Fixes: 87011737b715 ("mlx5: add software counters") Cc: stable@dpdk.org Signed-off-by: Shahaf Shuler <shahafs@mellanox.com> Acked-by: Yongseok Koh <yskoh@mellanox.com> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Diffstat (limited to 'drivers/net/mlx5/mlx5_stats.c')
-rw-r--r--drivers/net/mlx5/mlx5_stats.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/mlx5/mlx5_stats.c b/drivers/net/mlx5/mlx5_stats.c
index d443e13..06348c8 100644
--- a/drivers/net/mlx5/mlx5_stats.c
+++ b/drivers/net/mlx5/mlx5_stats.c
@@ -360,13 +360,13 @@ mlx5_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
tmp.q_opackets[idx] += txq->stats.opackets;
tmp.q_obytes[idx] += txq->stats.obytes;
#endif
- tmp.q_errors[idx] += txq->stats.odropped;
+ tmp.q_errors[idx] += txq->stats.oerrors;
}
#ifdef MLX5_PMD_SOFT_COUNTERS
tmp.opackets += txq->stats.opackets;
tmp.obytes += txq->stats.obytes;
#endif
- tmp.oerrors += txq->stats.odropped;
+ tmp.oerrors += txq->stats.oerrors;
}
#ifndef MLX5_PMD_SOFT_COUNTERS
/* FIXME: retrieve and add hardware counters. */