summaryrefslogtreecommitdiff
path: root/drivers/bus/pci/pci_common_uio.c
diff options
context:
space:
mode:
authorZhiyong Yang <zhiyong.yang@intel.com>2018-01-10 10:32:26 +0800
committerThomas Monjalon <thomas@monjalon.net>2018-01-12 01:04:22 +0100
commit6c7001480ac6356ff0a4995f3ed495ed9c866061 (patch)
tree3df7b8c281bc9347f2c99b079dc70d16b1058969 /drivers/bus/pci/pci_common_uio.c
parent3b792ed9c84003ffc78f0dbdd85ba9780d3b193d (diff)
downloaddpdk-6c7001480ac6356ff0a4995f3ed495ed9c866061.zip
dpdk-6c7001480ac6356ff0a4995f3ed495ed9c866061.tar.gz
dpdk-6c7001480ac6356ff0a4995f3ed495ed9c866061.tar.xz
bus/pci: fix interrupt handler type
For virtio legacy device, testpmd startup fails when using uio_pci_generic. The issue is caused by invoking the function pci_ioport_map. The correct value of intr_handle.type is already set before calling it, we should avoid overwriting the default value "RTE_INTR_HANDLE_UNKNOWN" in this function. Besides, the removal has no harm to other cases because it is set to 0 by a memset on the whole struct during allocation in the function pci_scan_one. Such assignments are removed in the meanwhile in pci_uio_map_resource(), pci_vfio_map_resource_primary() and pci_vfio_map_resource_secondary() in order to keep consistencies and avoid future questions. Fixes: 756ce64b1ecd ("eal: introduce PCI ioport API") Cc: stable@dpdk.org Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
Diffstat (limited to 'drivers/bus/pci/pci_common_uio.c')
-rw-r--r--drivers/bus/pci/pci_common_uio.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/bus/pci/pci_common_uio.c b/drivers/bus/pci/pci_common_uio.c
index dd84ec8..54bc20b 100644
--- a/drivers/bus/pci/pci_common_uio.c
+++ b/drivers/bus/pci/pci_common_uio.c
@@ -90,7 +90,6 @@ pci_uio_map_resource(struct rte_pci_device *dev)
dev->intr_handle.fd = -1;
dev->intr_handle.uio_cfg_fd = -1;
- dev->intr_handle.type = RTE_INTR_HANDLE_UNKNOWN;
/* secondary processes - use already recorded details */
if (rte_eal_process_type() != RTE_PROC_PRIMARY)