summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFerruh Yigit <ferruh.yigit@intel.com>2017-06-13 17:42:08 +0100
committerThomas Monjalon <thomas@monjalon.net>2017-06-14 19:48:09 +0200
commitc3698192940ca9786cb2871272a585638c50d194 (patch)
treef1a977d3a0841bde92132bc9157c567d9bcba0e8
parent6110b1c65ba01d2cce03b6c1640dfe519c6f5884 (diff)
downloaddpdk-c3698192940ca9786cb2871272a585638c50d194.zip
dpdk-c3698192940ca9786cb2871272a585638c50d194.tar.gz
dpdk-c3698192940ca9786cb2871272a585638c50d194.tar.xz
kni: fix build with gcc 7.1
build error: .../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c: In function ‘igb_kni_probe’: .../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c:2483:30: error: ‘%d’ directive output may be truncated writing between 1 and 5 bytes into a region of size between 0 and 11 [-Werror=format-truncation=] "%d.%d, 0x%08x, %d.%d.%d", ^~ .../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c:2483:8: note: directive argument in the range [0, 65535] "%d.%d, 0x%08x, %d.%d.%d", ^~~~~~~~~~~~~~~~~~~~~~~~~ .../dpdk/build/build/lib/librte_eal/linuxapp/kni/igb_main.c:2481:4: note: ‘snprintf’ output between 23 and 43 bytes into a destination of size 32 snprintf(adapter->fw_version, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(adapter->fw_version), ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ "%d.%d, 0x%08x, %d.%d.%d", ~~~~~~~~~~~~~~~~~~~~~~~~~~ fw.eep_major, fw.eep_minor, fw.etrack_id, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ fw.or_major, fw.or_build, fw.or_patch); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixed by increasing buffer size to 43 as suggested in compiler log. Fixes: b9ee370557f1 ("kni: update kernel driver ethtool baseline") Cc: stable@dpdk.org Reported-by: Nirmoy Das <ndas@suse.de> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> Reviewed-by: Markos Chandras <mchandras@suse.de>
-rw-r--r--lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
index d077b49..8667f29 100644
--- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
+++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
@@ -607,7 +607,7 @@ struct igb_adapter {
int int_mode;
u32 rss_queues;
u32 vmdq_pools;
- char fw_version[32];
+ char fw_version[43];
u32 wvbr;
struct igb_mac_addr *mac_table;
#ifdef CONFIG_IGB_VMDQ_NETDEV