summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorViacheslav Ovsiienko <viacheslavo@mellanox.com>2019-11-27 12:33:12 +0000
committerThomas Monjalon <thomas@monjalon.net>2019-11-27 16:25:11 +0100
commit57725162f05dfb9f81fa3bae76018488083f9493 (patch)
tree0eee4c6955083f65b4ed12b24a08971378d520b2
parenta0865f6f074880a2270f937d385070d1ae726bdf (diff)
downloaddpdk-57725162f05dfb9f81fa3bae76018488083f9493.zip
dpdk-57725162f05dfb9f81fa3bae76018488083f9493.tar.gz
dpdk-57725162f05dfb9f81fa3bae76018488083f9493.tar.xz
net/mlx5: fix legacy non-inline multi-packet performance
The legacy multi-packet write is the feature allowing to put multiple packets into one transmitting descriptor, this feature is supported by only NIC ConnectX-4LX. The number of packets should be limited to provide optimal size descriptor and better performance. Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template") Cc: stable@dpdk.org Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com> Acked-by: Matan Azrad <matan@mellanox.com>
-rw-r--r--drivers/net/mlx5/mlx5_prm.h2
-rw-r--r--drivers/net/mlx5/mlx5_rxtx.c4
2 files changed, 5 insertions, 1 deletions
diff --git a/drivers/net/mlx5/mlx5_prm.h b/drivers/net/mlx5/mlx5_prm.h
index 651006b..2bac6a7 100644
--- a/drivers/net/mlx5/mlx5_prm.h
+++ b/drivers/net/mlx5/mlx5_prm.h
@@ -99,6 +99,8 @@
* in tx burst routine at the moment of freeing multiple mbufs.
*/
#define MLX5_EMPW_MAX_PACKETS MLX5_TX_COMP_THRESH
+#define MLX5_MPW_MAX_PACKETS 6
+
/*
* Default packet length threshold to be inlined with
* ordinary SEND. Inlining saves the MR key search
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 73c16de..25d915c 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -3888,7 +3888,9 @@ mlx5_tx_burst_empw_simple(struct mlx5_txq_data *restrict txq,
next_empw:
assert(NB_SEGS(loc->mbuf) == 1);
- part = RTE_MIN(pkts_n, MLX5_EMPW_MAX_PACKETS);
+ part = RTE_MIN(pkts_n, MLX5_TXOFF_CONFIG(MPW) ?
+ MLX5_MPW_MAX_PACKETS :
+ MLX5_EMPW_MAX_PACKETS);
if (unlikely(loc->elts_free < part)) {
/* We have no enough elts to save all mbufs. */
if (unlikely(loc->elts_free < MLX5_EMPW_MIN_PACKETS))