summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLi Qiang <liq3ea@163.com>2019-04-16 13:05:14 +0800
committerThomas Monjalon <thomas@monjalon.net>2019-05-02 23:48:37 +0200
commit194a83d837472a27030e55af95b1103c90c2c63a (patch)
tree74b0fd24eb587a9ec0a9dfb3c1fc2055fe6b6752
parent5ca606ea484546c733bb04f301283b1ffef8922c (diff)
downloaddpdk-194a83d837472a27030e55af95b1103c90c2c63a.zip
dpdk-194a83d837472a27030e55af95b1103c90c2c63a.tar.gz
dpdk-194a83d837472a27030e55af95b1103c90c2c63a.tar.xz
raw/ifpga: fix file descriptor leak in error path
In rte_fpga_do_pr() function, if 'stat' return error the 'file_fd' is never closed thus leading a fd leak. This patch avoids this. Coverity issue: 279441 Fixes: ef1e8ede3da59e ("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: stable@dpdk.org Signed-off-by: Li Qiang <liq3ea@163.com> Acked-by: Rosen Xu <rosen.xu@intel.com>
-rw-r--r--drivers/raw/ifpga_rawdev/ifpga_rawdev.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
index 33b2511..41be1a2 100644
--- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
+++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c
@@ -292,7 +292,8 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int port_id,
if (ret) {
IFPGA_RAWDEV_PMD_ERR("stat on bitstream file failed: %s\n",
file_name);
- return -EINVAL;
+ ret = -EINVAL;
+ goto close_fd;
}
buffer_size = file_stat.st_size;
IFPGA_RAWDEV_PMD_INFO("bitstream file size: %zu\n", buffer_size);