summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStephen Hemminger <stephen@networkplumber.org>2019-11-08 10:00:35 -0800
committerDavid Marchand <david.marchand@redhat.com>2019-11-12 18:35:17 +0100
commit08a234788ee548796fd6b394c7e897a2bf1df1b3 (patch)
tree8015181cbd1b580e9e71bb1a8e0a1a6e6e0f9381
parent264a1598c543f52d63489ee663d91d161d44a7d3 (diff)
downloaddpdk-08a234788ee548796fd6b394c7e897a2bf1df1b3.zip
dpdk-08a234788ee548796fd6b394c7e897a2bf1df1b3.tar.gz
dpdk-08a234788ee548796fd6b394c7e897a2bf1df1b3.tar.xz
cmdline: remove unnecessary #ifdef
The #ifdef to conditionally include <sys/socket.h> on BSD is unnecessary. It is harmless to include the header on other OS's. An extra include is better than an #ifdef. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Olivier Matz <olivier.matz@6wind.com>
-rw-r--r--app/test-pmd/cmdline.c2
-rw-r--r--app/test/test_cmdline_ipaddr.c2
-rw-r--r--lib/librte_cmdline/cmdline_parse_ipaddr.c2
3 files changed, 0 insertions, 6 deletions
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 7d48fed..809c94a 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -11,9 +11,7 @@
#include <termios.h>
#include <unistd.h>
#include <inttypes.h>
-#ifdef RTE_EXEC_ENV_FREEBSD
#include <sys/socket.h>
-#endif
#include <netinet/in.h>
#include <sys/queue.h>
diff --git a/app/test/test_cmdline_ipaddr.c b/app/test/test_cmdline_ipaddr.c
index 315ac3a..088cd5a 100644
--- a/app/test/test_cmdline_ipaddr.c
+++ b/app/test/test_cmdline_ipaddr.c
@@ -6,9 +6,7 @@
#include <string.h>
#include <inttypes.h>
#include <netinet/in.h>
-#ifdef RTE_EXEC_ENV_FREEBSD
#include <sys/socket.h>
-#endif
#include <rte_string_fns.h>
diff --git a/lib/librte_cmdline/cmdline_parse_ipaddr.c b/lib/librte_cmdline/cmdline_parse_ipaddr.c
index 4de5ba3..f8dbdf2 100644
--- a/lib/librte_cmdline/cmdline_parse_ipaddr.c
+++ b/lib/librte_cmdline/cmdline_parse_ipaddr.c
@@ -13,9 +13,7 @@
#include <errno.h>
#include <arpa/inet.h>
#include <netinet/in.h>
-#ifdef RTE_EXEC_ENV_FREEBSD
#include <sys/socket.h>
-#endif
#include <rte_string_fns.h>