summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAmit Gupta <agupta3@marvell.com>2019-08-05 13:30:44 +0530
committerJerin Jacob <jerinj@marvell.com>2019-08-05 19:03:01 +0200
commit230dce6461b92f36c819f1cf29c0c0e0f8d11ea8 (patch)
tree59580b1e95cf65c69405c4c66349b7a13542e187
parente359e3b796b1fc15a600d87a1e380c71f77e8daa (diff)
downloaddpdk-stable-230dce6461b92f36c819f1cf29c0c0e0f8d11ea8.zip
dpdk-stable-230dce6461b92f36c819f1cf29c0c0e0f8d11ea8.tar.gz
dpdk-stable-230dce6461b92f36c819f1cf29c0c0e0f8d11ea8.tar.xz
net/thunderx: fix crash on detach
Fix the PCIe detach segfault by releasing eth_dev resources by adding nicvf cleanup support on PCI detach. Fixes: fdf91e0f2fac ("drivers/net: do not use ethdev driver") Cc: stable@dpdk.org Signed-off-by: Amit Gupta <agupta3@marvell.com> Acked-by: Jerin Jacob <jerinj@marvell.com>
-rw-r--r--drivers/net/thunderx/nicvf_ethdev.c12
1 files changed, 11 insertions, 1 deletions
diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c
index ec57692..56769ef 100644
--- a/drivers/net/thunderx/nicvf_ethdev.c
+++ b/drivers/net/thunderx/nicvf_ethdev.c
@@ -2083,6 +2083,16 @@ kvlist_free:
return ret;
}
static int
+nicvf_eth_dev_uninit(struct rte_eth_dev *dev)
+{
+ PMD_INIT_FUNC_TRACE();
+
+ if (rte_eal_process_type() == RTE_PROC_PRIMARY)
+ nicvf_dev_close(dev);
+
+ return 0;
+}
+static int
nicvf_eth_dev_init(struct rte_eth_dev *eth_dev)
{
int ret;
@@ -2256,7 +2266,7 @@ static int nicvf_eth_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
static int nicvf_eth_pci_remove(struct rte_pci_device *pci_dev)
{
- return rte_eth_dev_pci_generic_remove(pci_dev, NULL);
+ return rte_eth_dev_pci_generic_remove(pci_dev, nicvf_eth_dev_uninit);
}
static struct rte_pci_driver rte_nicvf_pmd = {