AgeCommit message (Collapse)Author
24 hoursnet/ice: fix packet type tableHEADmasterfor-next-netShougang Wang
According to comms package, index 94 should be MAC_IPV6_ICMP, not MAC_IPV4_ICMP. This patch fixes the issue. Fixes: 4cf29798b4c9 ("net/ice: fix packet type table") Cc: Signed-off-by: Shougang Wang <> Acked-by: Xiaolong Ye <>
48 hoursnet/netvsc: disable before changing RSS parametersStephen Hemminger
In order to change RSS parameters, the host requires that RSS is disable first. Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") Cc: Signed-off-by: Donald Lee <> Signed-off-by: Stephen Hemminger <> Tested-by: Dexuan Cui <> Tested-by: Abhishek Marathe <>
48 hoursnet/netvsc: fix RSS offload flagStephen Hemminger
The change to add OFFLOAD_RSS_HASH broke use of netvsc PMD with testpmd. The netvsc driver fails during configure step: Configuring Port 1 (socket 0) hn_dev_configure(): unsupported RX offload: 0x80000 Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload") Cc: Signed-off-by: Stephen Hemminger <>
2 daysnet/ice: disable TSO offload in vector pathTao Zhu
ICE choices VECTOR TX path or Basic TX path by macro ICE_NO_VECTOR_FLAGS. TSO offload only processed by Basic TX path. Fixes: f88de4694d94 ("net/ice: support Tx SSE vector") Cc: Signed-off-by: Tao Zhu <> Acked-by: Qi Zhang <>
2 daysnet/fm10k: fix descriptor VLAN field filling in TxLu Qiuwen
The VLAN field in the descriptor is not filled when ol_flags has no VLAN flag. When the caller sends some packets with VLAN tags, but other packets do not have VLAN tags, the behavior of the program cannot be determined. Fixes: 4b61d3bfa941 ("fm10k: add receive and tranmit") Cc: Signed-off-by: Lu Qiuwen <> Acked-by: Xiao Wang <>
3 daysnet/pcap: truncate packet if it is too largeZhike Wang
Previously large packet would be dropped, instead now it is better to keep it via truncating it. Signed-off-by: Zhike Wang <> Reviewed-by: Cian Ferriter <> Acked-by: Ferruh Yigit <>
3 daysapp/testpmd: fix device mcast list error handlingCiara Power
The multicast set list function now has a return value, which is checked by the calling functions. A rollback occurs on detection of failure, to realign local config with the device config. The error print statement in the function had included the port_id and mc_addr_nb values in the wrong order, these are now swapped. Fixes: 8fff667578a7 ("app/testpmd: new command to add/remove multicast MAC addresses") Cc: Signed-off-by: Ciara Power <> Reviewed-by: Ferruh Yigit <>
3 daysnet/bnxt: use macro for getting default VNICKalesh AP
BNXT_GET_DEFAULT_VNIC macro returns the default VNIC of the function and fixed all occurrences of code to use the macro. Signed-off-by: Kalesh AP <> Reviewed-by: Somnath Kotur <>
3 daysnet/bnxt: remove a log while deleting EM filtersKalesh AP
Remove an unnecessary log while deleting EM filters. Signed-off-by: Kalesh AP <> Reviewed-by: Somnath Kotur <>
3 daysnet/bnxt: refactor chip type selectionKalesh AP
Use switch-case statement to replace if-else statement. Signed-off-by: Kalesh AP <> Reviewed-by: Somnath Kotur <>
3 daysapp/testpmd: show MAC addresses added to a portKalesh AP
Patch adds a runtime function to display the unicast and multicast MAC addresses added to a port. Syntax: show port (port_id) macs|mcast_macs Usage: testpmd> show port 0 macs Number of MAC address added: 1 B0:26:28:7F:F5:C1 testpmd> testpmd> show port 0 mcast_macs Number of Multicast MAC address added: 0 testpmd> testpmd> mac_addr add 0 B0:26:28:7F:22:33 testpmd> mac_addr add 0 B0:26:28:7F:22:34 testpmd> show port 0 macs Number of MAC address added: 3 B0:26:28:7F:F5:C1 B0:26:28:7F:22:33 B0:26:28:7F:22:34 testpmd> testpmd> mac_addr remove 0 B0:26:28:7F:22:33 testpmd> show port 0 macs Number of MAC address added: 2 B0:26:28:7F:F5:C1 B0:26:28:7F:22:34 Signed-off-by: Kalesh AP <> Reviewed-by: Ajit Khaparde <> Reviewed-by: Ferruh Yigit <>
8 dayseal/linux: fix build error on RHEL 7.6David Marchand
Previous fix gives hiccups to gcc on RHEL 7.6: == Build lib/librte_eal/linux/eal CC eal_interrupts.o ...lib/librte_eal/linux/eal/eal_interrupts.c: In function ‘eal_intr_thread_main’: ...lib/librte_eal/linux/eal/eal_interrupts.c:1048:9: error: missing initializer for field ‘events’ of ‘struct epoll_event’ [-Werror=missing-field-initializers] struct epoll_event ev = { }; ^ In file included from ...lib/librte_eal/linux/eal/eal_interrupts.c:15:0: /usr/include/sys/epoll.h:89:12: note: ‘events’ declared here uint32_t events; /* Epoll events */ ^ ...lib/librte_eal/linux/eal/eal_interrupts.c: At top level: cc1: error: unrecognized command line option "-Wno-address-of-packed-member" [-Werror] cc1: all warnings being treated as errors Fixes: e0ab8020ac2a ("eal/linux: fix uninitialized data valgrind warning") Cc: Reported-by: Andrew Rybchenko <> Signed-off-by: David Marchand <>
8 dayseal/linux: fix uninitialized data valgrind warningStephen Hemminger
Valgrind reports that eal interrupt thread is calling epoll_ctl with uninitialized data. This is a false positive, because the kernel is not going to care about the unused bits in the union but trivial to fix by initializing it. Fixes: af75078fece3 ("first public release") Cc: Signed-off-by: Stephen Hemminger <> Acked-by: David Marchand <>
10 daysversion: 20.02-rc0Thomas Monjalon
Start a new release cycle with empty release notes. Signed-off-by: Thomas Monjalon <>
13 daysversion: 19.11.0Thomas Monjalon
Signed-off-by: Thomas Monjalon <>
13 daysconfig: add pkgconfig for arm64Ali Alnubani
Meson fails to find a pkg-config executable if pkgconfig isn't set for aarch64. The environment variable `PKG_CONFIG_PATH` is useless in this case, and meson fails to locate dependencies that are built in non-standard paths. Signed-off-by: Ali Alnubani <> Acked-by: Bruce Richardson <>
13 daysdoc: update arm64 cross build tool versionJoyce Kong
Update the cross build tool version to gcc8.3. Fixes: 01add9da25cd ("doc: add cross compiling guide") Cc: Signed-off-by: Joyce Kong <> Reviewed-by: Gavin Hu <> Acked-by: Jerin Jacob <>
13 daysdoc: update libnuma dependency on arm64Ali Alnubani
Previous versions of numactl may produce the following error on some systems (at least on Fedora 30 and RHEL7.4): ./.libs/ undefined reference to `minor' ./.libs/ undefined reference to `major' collect2: error: ld returned 1 exit status This was fixed in upstream commit: The fix is available in v2.0.13. Signed-off-by: Ali Alnubani <> Reviewed-by: Ruifeng Wang <> Acked-by: Gavin Hu <>
13 daysdoc: update example output in FreeBSD guideBruce Richardson
The output of running the helloworld example on FreeBSD was a little out-of-date and can be shortened by using the latest version of DPDK. Update appropriately. Signed-off-by: Bruce Richardson <> Acked-by: Anatoly Burakov <>
13 daysdoc: remove reference to old version of FreeBSDBruce Richardson
FreeBSD 10 is now EOL and all testing with DPDK takes place on BSD versions 11 and 12, so we can just remove the note. The BSD ports are supported on all non-EOL versions of BSD. Signed-off-by: Bruce Richardson <> Acked-by: Anatoly Burakov <>
13 daysdoc: reorder meson and make build instructions for ArmBruce Richardson
Since the meson instructions are the simpler of the two sets, and also the ones most future-proof, put those first in the user documentation with make instructions following them. Signed-off-by: Bruce Richardson <> Acked-by: Gavin Hu <>
13 daysdoc: add building with meson to Linux guideBruce Richardson
Add instructions on building DPDK and using the pkg-config file to the linux GSG. Signed-off-by: Bruce Richardson <> Acked-by: Anatoly Burakov <>
13 daysdoc: update system requirements in Linux guideBruce Richardson
Update the system requirements section of the doc to cover builds with meson and ninja. This involves updating the package dependencies to include meson, ninja and python 3.5, and also updating the optional dependencies section to explain that the components are enabled/disabled automatically by meson. As part of this update, the relevant sections were simplified to keep the document shorter. For mandatory requirements, we can refer to the various distro's development tools package groups rather than requiring gcc, core tools etc. individually. The optional package list was very incomplete, and if complete would duplicate information in the individual driver's guides. Therefore we can simplify it by listing only the library optional requirements and referring users to the driver docs to find details on their dependencies. Signed-off-by: Bruce Richardson <>
13 daysdoc: clarify path selection in virtio guideYinan Wang
Add virtio paths selection and usage introduction for better virtio usability. Signed-off-by: Yinan Wang <> Acked-by: Tiwei Bie <> Reviewed-by: Maxime Coquelin <>
13 daysdoc: update offload dependencies in mlx5 guideRaslan Darawsheh
Fix OFED and rdma-core versions for current offloads. Add new offloads minimum versions. Signed-off-by: Raslan Darawsheh <> Acked-by: Ori Kam <>
13 daysdoc: add tested platforms with Mellanox NICsRaslan Darawsheh
Signed-off-by: Raslan Darawsheh <>
13 daysdevtools: control location of test buildsBruce Richardson
By default, both and scripts create the builds they generate in the current working directory, leading to a large number of build directories being present when testing patches. This patchset modifies both scripts to use a DPDK_BUILD_TEST_DIR environment variable to control where the build outputs are put. For example, doing: export DPDK_BUILD_TEST_DIR=__builds ./devtools/ && ./devtools/ \ x86_64-native-linux-clang+shared i686-native-linux-gcc gives a "__builds" directory with 14 meson and 2 make builds (with the meson build count depending on compiler availability) Signed-off-by: Bruce Richardson <> Signed-off-by: Thomas Monjalon <> Acked-by: David Marchand <>
14 daysdevtools: move ABI scripts from buildtoolsDavid Marchand
Those scripts are only used by developers and not part of the build process. Move them to devtools so they are not installed. Signed-off-by: David Marchand <> Acked-by: Thomas Monjalon <>
14 daysexamples/fips_validation: fix vectors for AES-GCMSucharitha Sarananaga
Test vectors for AES-GCM need to be populated by using aead member and not cipher_auth. Using incorrect member would result in failures when AES-GCM with non-zero AAD is tried. Bugzilla ID: 360 Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing") Signed-off-by: Anoob Joseph <> Signed-off-by: Sucharitha Sarananaga <>
14 daysdrivers: update copyright for NXP filesSachin Saxena
Signed-off-by: Sachin Saxena <> Acked-by: Hemant Agrawal <>
14 dayskni: fix build with Linux 4.9.xFerruh Yigit
The 'get_user_pages_remote()' API is updated in kernel 4.10.0 [1], but the check added as > 4.9.0, this logic is broken for kernels 4.9.x, because they justify > 4.9.0 check but have the old API. Fixing the check as >= 4.10.0 [1] commit 5b56d49fc31d ("mm: add locked parameter to get_user_pages_remote()") Fixes: d965af9e8ae1 ("kni: increase kernel version requirement for VA") Reported-by: Andrew Rybchenko <> Suggested-by: David Marchand <> Signed-off-by: Ferruh Yigit <> Tested-by: Andrew Rybchenko <> Reviewed-by: David Marchand <>
2019-11-28usertools: fix typo in SPDX tag of telemetry scriptBruce Richardson
There is a typo in the SPDX tag, which is down as an "SPDK" tag. One-character change should be all that is needed. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: Reported-by: Stephen Hemminger <> Signed-off-by: Bruce Richardson <> Acked-by: Kevin Traynor <>
2019-11-28eal/windows: remove tail queue license boilerplateStephen Hemminger
The BSD license is already handled by SPDX tag. Signed-off-by: Stephen Hemminger <> Acked-by: Hemant Agrawal <>
2019-11-28eal: remove reciprocal divide license boilerplateStephen Hemminger
No need for extra language, covered by SPDX tag. Signed-off-by: Stephen Hemminger <>
2019-11-28eal: remove uuid license boilerplateStephen Hemminger
License type is already clear from SPDX tag. Signed-off-by: Stephen Hemminger <> Acked-by: Hemant Agrawal <>
2019-11-28examples/l2fwd-event: add missing SPDX license headerStephen Hemminger
Add same tag as other files in this example. Signed-off-by: Stephen Hemminger <> Acked-by: Pavan Nikhilesh <>
2019-11-28doc: use SPDX license tag for vhost PMD guideTetsuya Mukawa
Signed-off-by: Tetsuya Mukawa <>
2019-11-28doc: fix copyright notice in AVP guideAllain Legacy
Aligning the Wind River copyright notices to be consistent with the other files which bare the Wind River copyright notice. Fixes: 32113d352d3b ("doc: replace license text with SPDX tag in AVP guide") Signed-off-by: Allain Legacy <>
2019-11-28test/cfgfile: replace license text with SPDX tagAllain Legacy
Replacing full license text with SPDX tag. Signed-off-by: Allain Legacy <> Acked-by: Stephen Hemminger <>
2019-11-28test/thash: replace license text with SPDX tagVladimir Medvedkin
Signed-off-by: Vladimir Medvedkin <> Acked-by: Hemant Agrawal <>
2019-11-28port: replace license text with SPDX tagXiaolong Ye
Signed-off-by: Xiaolong Ye <> Acked-by: Bruce Richardson <> Acked-by: Cristian Dumitrescu <> Acked-by: Ethan Zhuang <>
2019-11-28net/nfp: replace license text with SPDX tagHemant Agrawal
Signed-off-by: Hemant Agrawal <> Acked-by: Heinrich Kuhn <>
2019-11-28doc: add tested Marvell integrated NIC platformsJerin Jacob
Add tested Marvell integrated NIC platforms to v19.11 release notes. Signed-off-by: Jerin Jacob <>
2019-11-28doc: add tested Intel platforms with Intel NICsWenjie Li
Add tested Intel platforms with Intel NICs to v19.11 release notes. Signed-off-by: Wenjie Li <>
2019-11-28doc: add codespell config in contributing guideKevin Traynor
Document the config to use codespell with Signed-off-by: Kevin Traynor <>
2019-11-28maintainers: update armv8 crypto PMDRuifeng Wang
It is expected to update this PMD to be in line with Arm's crypto library. Update the maintainership to refect the change. Signed-off-by: Ruifeng Wang <> Reviewed-by: Gavin Hu <> Acked-by: Jerin Jacob <>
2019-11-28maintainers: update for NFPHeinrich Kuhn
As Alejandro is no longer with Netronome we appointed two new maintainers for the Netronome PMD Signed-off-by: Heinrich Kuhn <>
2019-11-28devtools: check coverity and bugzilla tagsDavid Marchand
Let's try to check for discrepancies in coverity and bugzilla tags. The contributing guide specifies that: - for coverity issues, the tag is 'Coverity issue:' - for bugzilla issues, the tag is 'Bugzilla ID:' Signed-off-by: David Marchand <> Acked-by: Kevin Traynor <>
2019-11-28devtools: reset compilation flags for each targetDavid Marchand
Same idea than overriding PATH and PKG_CONFIG_PATH, it can be quite useful to override compilation flags like CFLAGS, CPPFLAGS and LDFLAGS for cross compilation or libraries that won't provide a pkg-config file. Fixes: 272236741258 ("devtools: load target-specific compilation environment") Signed-off-by: David Marchand <>
2019-11-27git: ignore more build directoriesThomas Monjalon
Build directories commonly have compiler in their names. In order to filter build directories not starting with "build-" (common with make), patterns for gcc and clang are added to .gitignore. Signed-off-by: Thomas Monjalon <> Acked-by: David Marchand <>