summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAjit Khaparde <ajit.khaparde@broadcom.com>2019-11-19 19:00:23 -0800
committerFerruh Yigit <ferruh.yigit@intel.com>2019-11-20 17:36:06 +0100
commitfb4921ab4cb7238a22160ac61280ad647a3dcc6c (patch)
tree7f0000b85c408fac71a4cd29a518b2198e48ea32
parentd9aa878b795bbe18b2587952bcfcd2f371b2d3fe (diff)
downloaddpdk-next-net-intel-fb4921ab4cb7238a22160ac61280ad647a3dcc6c.zip
dpdk-next-net-intel-fb4921ab4cb7238a22160ac61280ad647a3dcc6c.tar.gz
dpdk-next-net-intel-fb4921ab4cb7238a22160ac61280ad647a3dcc6c.tar.xz
net/bnxt: fix flow check for null spec and mask
bnxt_validate_and_parse_flow_type already has protocol specific NULL checks for rte_flow_item spec and mask and take actions accordingly. A check at the top of the loop is redundant and is preventing the protocol specific checks from being executed. Fixes: b7e01f386059 ("net/bnxt: handle cleanup if flow creation fails") Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com> Reviewed-by: Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
-rw-r--r--drivers/net/bnxt/bnxt_flow.c8
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
index 5af5714..76e9584 100644
--- a/drivers/net/bnxt/bnxt_flow.c
+++ b/drivers/net/bnxt/bnxt_flow.c
@@ -177,14 +177,6 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp,
return -rte_errno;
}
- if (!item->spec || !item->mask) {
- rte_flow_error_set(error, EINVAL,
- RTE_FLOW_ERROR_TYPE_ITEM,
- item,
- "spec/mask is NULL");
- return -rte_errno;
- }
-
switch (item->type) {
case RTE_FLOW_ITEM_TYPE_ANY:
inner =