summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatan Azrad <matan@mellanox.com>2019-11-26 09:04:10 +0000
committerFerruh Yigit <ferruh.yigit@intel.com>2019-11-26 18:05:15 +0100
commit64edb05e29c82260a0bd1000a20023d20c123e41 (patch)
treec6f1863d7c5ea6c2c2beacaf029a933fee9a10ed
parentac466a1d6c7892cc835e1ccbcdc83336c2f44701 (diff)
downloaddpdk-next-net-intel-64edb05e29c82260a0bd1000a20023d20c123e41.zip
dpdk-next-net-intel-64edb05e29c82260a0bd1000a20023d20c123e41.tar.gz
dpdk-next-net-intel-64edb05e29c82260a0bd1000a20023d20c123e41.tar.xz
ethdev: fix item expansion for RSS flow
When the last item in flow pattern includes "next protocol" field which is relevant for RSS flow expansion, a new item is added to the pattern according to the "next protocol" field. This field is called missed field. The missed field wrongly was not initialized what caused to some of the flow item fields to contain garbage values. As a result, the PMDs internal flow engine may crash. For example, the spec value may include garbage pointer and to cause crash. Initialize the missed field with zeroes. Fixes: fc2dd8dd492f ("ethdev: fix expand RSS flows") Cc: stable@dpdk.org Signed-off-by: Matan Azrad <matan@mellanox.com> Acked-by: Ori Kam <orika@mellanox.com>
-rw-r--r--lib/librte_ethdev/rte_flow.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c
index d7f29e5..87a3e8c 100644
--- a/lib/librte_ethdev/rte_flow.c
+++ b/lib/librte_ethdev/rte_flow.c
@@ -1071,6 +1071,7 @@ rte_flow_expand_rss(struct rte_flow_expand_rss *buf, size_t size,
int elt = 0;
const struct rte_flow_item *last_item = NULL;
+ memset(&missed_item, 0, sizeof(missed_item));
lsize = offsetof(struct rte_flow_expand_rss, entry) +
elt_n * sizeof(buf->entry[0]);
if (lsize <= size) {