summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Rybchenko <arybchenko@solarflare.com>2017-11-14 11:32:34 +0000
committerThomas Monjalon <thomas@monjalon.net>2017-11-14 18:55:41 +0100
commitfdd7361b68021d049da9085680d55d2298c0ca3b (patch)
tree4f1ccc348dfb8cd1486330ab05e7f2309d1df67f
parentcb98affeefff891cfce331cb88e0e93d006693a5 (diff)
downloaddpdk-draft-cli-fdd7361b68021d049da9085680d55d2298c0ca3b.zip
dpdk-draft-cli-fdd7361b68021d049da9085680d55d2298c0ca3b.tar.gz
dpdk-draft-cli-fdd7361b68021d049da9085680d55d2298c0ca3b.tar.xz
net/sfc: avoid Rx queue setup failure if thresholds are set
Rx queue prefetch, host and writeback thresholds are used for performance fine-tuning and not applicable to Solarflare NICs. It is safe to just log warning and do not fail Rx queue setup to be more friendly to DPDK applications which hardcode it. Fixes: ce35b05c635e ("net/sfc: implement Rx queue setup release operations") Cc: stable@dpdk.org Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
-rw-r--r--drivers/net/sfc/sfc_rx.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c
index 2ae095b..7816393 100644
--- a/drivers/net/sfc/sfc_rx.c
+++ b/drivers/net/sfc/sfc_rx.c
@@ -780,9 +780,8 @@ sfc_rx_qcheck_conf(struct sfc_adapter *sa, uint16_t nb_rx_desc,
if (rx_conf->rx_thresh.pthresh != 0 ||
rx_conf->rx_thresh.hthresh != 0 ||
rx_conf->rx_thresh.wthresh != 0) {
- sfc_err(sa,
+ sfc_warn(sa,
"RxQ prefetch/host/writeback thresholds are not supported");
- rc = EINVAL;
}
if (rx_conf->rx_free_thresh > rx_free_thresh_max) {