summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Rybchenko <arybchenko@solarflare.com>2017-11-14 11:32:35 +0000
committerThomas Monjalon <thomas@monjalon.net>2017-11-14 18:57:22 +0100
commit048da2530d0d02c00a6a509c3351e5953817ffea (patch)
treef6c2bf30d3771c0d19eadb3aa4c088d24b964611
parentfdd7361b68021d049da9085680d55d2298c0ca3b (diff)
downloaddpdk-draft-cli-048da2530d0d02c00a6a509c3351e5953817ffea.zip
dpdk-draft-cli-048da2530d0d02c00a6a509c3351e5953817ffea.tar.gz
dpdk-draft-cli-048da2530d0d02c00a6a509c3351e5953817ffea.tar.xz
net/sfc: avoid Tx queue setup failure if thresholds are set
Tx queue prefetch, host and writeback thresholds are used for performance fine-tuning and not applicable to Solarflare NICs. It is safe to just log warning and do not fail Tx queue setup to be more friendly to DPDK applications which hardcode it. Fixes: b1b7ad933b39 ("net/sfc: set up and release Tx queues") Cc: stable@dpdk.org Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
-rw-r--r--drivers/net/sfc/sfc_tx.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/sfc/sfc_tx.c b/drivers/net/sfc/sfc_tx.c
index 127d59e..d1320f4 100644
--- a/drivers/net/sfc/sfc_tx.c
+++ b/drivers/net/sfc/sfc_tx.c
@@ -79,9 +79,8 @@ sfc_tx_qcheck_conf(struct sfc_adapter *sa, uint16_t nb_tx_desc,
if (tx_conf->tx_thresh.pthresh != 0 ||
tx_conf->tx_thresh.hthresh != 0 ||
tx_conf->tx_thresh.wthresh != 0) {
- sfc_err(sa,
+ sfc_warn(sa,
"prefetch/host/writeback thresholds are not supported");
- rc = EINVAL;
}
if (((flags & ETH_TXQ_FLAGS_NOMULTSEGS) == 0) &&