AgeCommit message (Collapse)Author
2017-11-13version: 17.11-rc4v17.11-rc4Thomas Monjalon
Signed-off-by: Thomas Monjalon <>
2017-11-13doc: add tested platforms with Mellanox NICsRaslan Darawsheh
Signed-off-by: Raslan Darawsheh <>
2017-11-13doc: fix a typo in EAL guideRami Rosen
Fix an error in DPDK programmer's guide (EAL section): it should be rte_thread_get_affinity() instead of rte_pthread_get_affinity(). Signed-off-by: Rami Rosen <> Acked-by: John McNamara <>
2017-11-13doc: fix a typo in pipeline app guideRami Rosen
This patch fixes a trivial typo in ip pipeline app guide. Signed-off-by: Rami Rosen <> Acked-by: Cristian Dumitrescu <> Acked-by: John McNamara <>
2017-11-13usertools: fix a typo in bind scriptPavel Shirshov
Signed-off-by: Pavel Shirshov <>
2017-11-13lib: fix typosPavel Shirshov
Signed-off-by: Pavel Shirshov <>
2017-11-12bus/pci: fix a typo in doxygen file descriptionJerin Jacob
Fixes: 764bf26873b9 ("add FreeBSD support") Signed-off-by: Jerin Jacob <>
2017-11-12net/virtio: fix memory leak on failurePengzhen Liu
In function eth_virtio_dev_init(), dynamic memory stored in "eth_dev->data->mac_addrs" variable and it is not freed when function return, this is a possible memory leak. Fixes: 8ced1542f7a3 ("net/virtio: eth_dev->data->mac_addrs is not freed") Cc: Signed-off-by: Pengzhen Liu <> Acked-by: Yuanhan Liu <>
2017-11-12ring: guarantee load/load order in enqueue and dequeueJia He
We watched a rte panic of mbuf_autotest in our qualcomm arm64 server (Amberwing). Root cause: In __rte_ring_move_cons_head() ... do { /* Restore n as it may change every loop */ n = max; *old_head = r->cons.head; //1st load const uint32_t prod_tail = r->prod.tail; //2nd load In weak memory order architectures (powerpc,arm), the 2nd load might be reodered before the 1st load, that makes *entries is bigger than we wanted. This nasty reording messed enque/deque up. cpu1(producer) cpu2(consumer) cpu3(consumer) load r->prod.tail in enqueue: load r->cons.tail load r->prod.head store r->prod.tail load r->cons.head load r->prod.tail ... store r->cons.{head,tail} load r->cons.head Then, r->cons.head will be bigger than prod_tail, then make *entries very big and the consumer will go forward incorrectly. After this patch, the old cons.head will be recaculated after failure of rte_atomic32_cmpset There is no such issue on X86, because X86 is strong memory order model. But rte_smp_rmb() doesn't have impact on runtime performance on X86, so keep the same code without architectures specific concerns. Fixes: 50d769054872 ("ring: add burst API") Cc: Signed-off-by: Jia He <> Signed-off-by: Jie Liu <> Signed-off-by: Bing Zhao <> Acked-by: Jerin Jacob <> Acked-by: Jianbo Liu <>
2017-11-12maintainers: update PTP client examplePablo de Lara
Signed-off-by: Pablo de Lara <> Acked-by: Daniel Mrzyglod <> Acked-by: John McNamara <>
2017-11-12maintainers: update job stats libraryPablo de Lara
Signed-off-by: Pablo de Lara <> Acked-by: Pawel Wodkowski <> Acked-by: John McNamara <>
2017-11-12maintainers: update for fm10kXiao Wang
Signed-off-by: Xiao Wang <> Acked-by: Helin Zhang <>
2017-11-12maintainers: resign from mlx4 maintenanceNelio Laranjeiro
I have been a little too busy these past months and could not follow all the re-work of this PMD. So the best thing for this PMD would be to move the mlx4 maintenance to more involved people. Cc: Signed-off-by: Nelio Laranjeiro <>
2017-11-12maintainers: claim maintainership of VDEV busJianfeng Tan
Signed-off-by: Jianfeng Tan <> Acked-by: Thomas Monjalon <> Acked-by: Zhiyong Yang <>
2017-11-12maintainers: fill git trees for net and crypto APIThomas Monjalon
The ethdev API (including rte_flow) is managed in the dpdk-next-net tree. The crypto API is managed in the dpdk-next-crypto tree. Signed-off-by: Thomas Monjalon <>
2017-11-12doc: mention 17.11 LTS in contributing guideLuca Boccassi
Signed-off-by: Luca Boccassi <> Acked-by: John McNamara <> Acked-by: Thomas Monjalon <>
2017-11-12doc: update API/ABI policyBruce Richardson
Following agreement at the DPDK Technical Board meeting of 2017-10-13 [1], update the documentation with the ABI/API policy changes. [1] Signed-off-by: Bruce Richardson <> Acked-by: John McNamara <> Acked-by: Yuanhan Liu <> Acked-by: Kevin Traynor <> Acked-by: Thomas Monjalon <>
2017-11-12doc: update deprecation of ethdev offload APIShahaf Shuler
Update deprecation notice for the new ethdev offloads API. Deprecation of the old offloads API is set to 18.05. Signed-off-by: Shahaf Shuler <> Acked-by: Andrew Rybchenko <> Acked-by: Konstantin Ananyev <> Acked-by: Thomas Monjalon <>
2017-11-12doc: postpone devargs clean-upGaetan Rivet
These changes were planned for 17.11 but were proposed too late. Postpone those to v18.02 instead. Signed-off-by: Gaetan Rivet <>
2017-11-12doc: update release notes for 17.11John McNamara
Fix grammar, spelling and formatting of DPDK 17.11 release notes. Signed-off-by: John McNamara <>
2017-11-12doc: add tested Intel platforms with Intel NICsYulong Pei
Add tested Intel platforms with Intel NICs to the release note. Signed-off-by: Yulong Pei <>
2017-11-12doc: fix mempool option in octeontx guideSantosh Shukla
Fixes: f820b5896631 ("doc: add octeontx ethdev driver documentation") Signed-off-by: Santosh Shukla <> Acked-by: Jerin Jacob <> Acked-by: John McNamara <>
2017-11-12doc: add octeontx mempool guideSantosh Shukla
This commit adds a section to the docs listing the mempool device PMDs available. It then adds the octeontx fpavf mempool PMD to the listed mempool devices. Signed-off-by: Santosh Shukla <> Acked-by: John McNamara <>
2017-11-12doc: add octeontx platform guideSantosh Shukla
This commit adds a section to the docs listing the platform guide for the PMDs. It then adds the octeontx platform guide to the listed platform devices. Patch also removes platform specific duplicate setup information from eventdev/octeontx.rst, nics/octeontx.rst and update to plaform/octeontx.rst. Signed-off-by: Santosh Shukla <> Acked-by: John McNamara <>
2017-11-12doc: update mlx4 documentationMoti Haimovsky
This updates mlx4 documentation and DPDK release notes to reflect the PMD support for rdma-core from linux-rdma. - PMD is now freed from Mellanox OFED and now only depends on the public rdma-core package (v15 and above) instead. (see This PMD should run under Linux v4.14 and above. - In case any of the above requirements can't be satisfied, Mellanox OFED v4.2 and above also provide an updated rdma-core as well back-ported kernel modules for most Linux distributions and previous Linux versions. (see Signed-off-by: Moti Haimovsky <> Acked-by: Adrien Mazarguil <>
2017-11-12doc: remove mlx4 Rx inline supportMoti Haimovsky
This commit removes the stale MLX4_INLINE_RECV_SIZE environment variable from the documentation. Fixes: 056eaf2e6d55 ("net/mlx4: drop inline receive support") Signed-off-by: Moti Haimovsky <> Acked-by: Adrien Mazarguil <>
2017-11-12doc: remove mlx4 Tx inline compilation optionMoti Haimovsky
This patch removes the stale CONFIG_RTE_LIBRTE_MLX4_MAX_INLINE compilation option from the documentation. Fixes: 586db080585b ("net/mlx4: remove Tx inline compilation option") Signed-off-by: Moti Haimovsky <> Acked-by: Adrien Mazarguil <>
2017-11-12doc: add inline crypto featureRadu Nicolau
Signed-off-by: Radu Nicolau <>
2017-11-12doc: move fast mbuf free feature in net guideThomas Monjalon
The feature was added at the end of the table. And the description was between the anchor _nic_features_timesync and its title. It is moved near related features with a new anchor. It is also renamed from "mbuf fast free" to "fast mbuf free". Fixes: d6f90afd3070 ("ethdev: add mbuf fast free Tx offload") Signed-off-by: Thomas Monjalon <> Acked-by: Ferruh Yigit <>
2017-11-12pdump: fix possible mbuf leak on failureIlya V. Matveychikov
If pdump_pktmbuf_copy_data() fails it's possible to have segment leak as rte_pktmbuf_free() only handles m_dup chain but not the seg just allocated and yet not chained. Fixes: 278f945402c5 ("pdump: add new library for packet capture") Signed-off-by: Ilya V. Matveychikov <>
2017-11-12examples/ipv4_multicast: fix segments number typeIlya V. Matveychikov
Fixes: 97cb466d65c9 ("mbuf: use 2 bytes for port and nb segments") Signed-off-by: Ilya V. Matveychikov <>
2017-11-12test/memory: fix autotest parsingRadoslaw Biernacki
This patch fixes three problems in memory autotest: - the regex for IOVA - missing validation of second and following output lines - propagation of error to consecutive tests - conversion base for mem size (hex indtead of dec) First fix is for changes introduced with IOVA, the regex was not updated which lead to unit test failure. Patch now also uses loop for line outputs processing to verify more than just one line. By this we also satisfy the pexpect() and scan the "Test OK"/"Test Failed" so in case of error all output lines are consumed and does not break the consecutive test (error does not propagate). Fixes: 7ba49d39f14c ("mem: rename segment address from physical to IOVA") Fixes: b4ce15aa2bc7 ("app/test: fix memory autotest") Signed-off-by: Radoslaw Biernacki <>
2017-11-11test/memzone: fix memory leakRadoslaw Biernacki
This patch fixes the memory leaks in memzone_autotest. Those memory leaks lead to failures in tests from the same testing group due to out of memory problems. With introduction of rte_memzone_free() it is now possible to free the memzone. Fix uses this API call to make a clean after each test case. Fixes: ff909fe21f0a ("mem: introduce memzone freeing") Cc: Signed-off-by: Radoslaw Biernacki <>
2017-11-11app/testpmd: remove port status check from TM commandJasvinder Singh
Currently, testpmd CLI doesn't permit to add leaf and non-leaf node when port is started. It doesn't work in case of i40e device as DCB configuration is deleted when port is stopped. Therefore, removes the port status check before invoking leaf and nonleaf node API in the cli. If needed, device can add port status check at the driver layer. Signed-off-by: Jasvinder Singh <> Acked-by: Wenzhuo Lu <>
2017-11-11eal: fix an include guard commentJerin Jacob
Fixes: af75078fece3 ("first public release") Signed-off-by: Jerin Jacob <>
2017-11-11net/virtio: fix Rx interrupt with VFIOZhiyong Yang
When running l3fwd-power to test virtio rxq interrupt using vfio pci noiommu mode, startup fails. In the function virtio_read_caps, the code if (flags & PCI_MSIX_ENABLE) intends to double check if vfio msix is enabled or not. However, it is not enable at that time. So use_msix is assigned to "0", not "1", which causes the failure of configuring rxq intr in l3fwd-power. This patch adds the function "vtpci_msix_detect" to detect the status of msix when interrupt changes happen. In the meanwhile, virtio_intr_enable/disable are introduced to wrap rte_intr_enable/disable to enhance the ability to detect msix. use_msix can indicate three different msix status by: VIRTIO_MSIX_NONE (0) VIRTIO_MSIX_DISABLED (1) VIRTIO_MSIX_ENABLED (2) Fixes: cb482cb3a305 ("net/virtio: fix MAC address read") Cc: Signed-off-by: Zhiyong Yang <> Acked-by: Jianfeng Tan <> Acked-by: Maxime Coquelin <>
2017-11-11net/mlx5: fix link speed bitmasksEdward Makarov
The constant ETHTOOL_LINK_MODE_1000baseT_Full_BIT and the others like that in mlx5_link_update_unlocked_gs must be bit masks but unfortunately they are bit numbers. This commit fixes the issue. Fixes: 188408719888 ("net/mlx5: fix support for newer link speeds") Cc: Signed-off-by: Edward Makarov <> Acked-by: Nelio Laranjeiro <>
2017-11-11net/mlx4: fix missing stamp during Tx completionMatan Azrad
After processing completed packets, the owner bit of each TXBB comprised in its WQEs must be invalidated. The loop stops short of processing the last WQE. Fixes: c3c977bbecbd ("net/mlx4: add Tx bypassing Verbs") Signed-off-by: Matan Azrad <> Acked-by: Adrien Mazarguil <>
2017-11-10net/bnxt: fix link handling and configurationAjit Khaparde
Remove a case where we were sending a deprecated field to the FW. There is no need to send auto_link_speed to the FW. Also set the auto_mode correctly depending on the setting requested. Fixes: 7bc8e9a227cc ("net/bnxt: support async link notification") Cc: Signed-off-by: Ajit Khaparde <>
2017-11-10net/bnxt: fix duplicate creation of ntuple filterAjit Khaparde
Prevent the creation of duplicate 5tuple filters. Fixes: b7435d660a8c ("net/bnxt: add ntuple filtering support") Signed-off-by: Ajit Khaparde <>
2017-11-10net/nfp: fix possible memory leakAlejandro Lucero
Memory allocated was not being released in any exit path. Coverity issue: 195030 Fixes: 48e2255f1b63 ("net/nfp: add NSP support for HW link configuration") Signed-off-by: Alejandro Lucero <>
2017-11-10net/nfp: fix null pointer checkAlejandro Lucero
First, the received pointer was not checked before. Then the pointer from malloc was not the one used in the existing check. Coverity issue: 195027 Fixes: ad60bca34899 ("net/nfp: read PF port MAC addr using NSP") Signed-off-by: Alejandro Lucero <>
2017-11-10net/nfp: fix possible bad shif operationAlejandro Lucero
We do not know how big can the BAR be, but we know anything less than 1MB is an error. This BAR needs to be big enough for accessing most of NFP internals. Coverity issue: 195024 Fixes: d12206e00590 ("net/nfp: add NSP user space interface") Signed-off-by: Alejandro Lucero <>
2017-11-10net/nfp: fix checking function return valueAlejandro Lucero
The fstat function could return a value that indicates an error condition. If this is not checked, the error condition may not be handled correctly. Coverity issue: 195019 Fixes: f37d8a4b67b2 ("net/nfp: add NSP FW upload command") Signed-off-by: Alejandro Lucero <>
2017-11-10net/nfp: fix resource leakAlejandro Lucero
File descriptor is not released in any potential exit path inside the function. Coverity issue: 195018 Fixes: f37d8a4b67b2 ("net/nfp: add NSP FW upload command") Signed-off-by: Alejandro Lucero <>
2017-11-10net/nfp: fix memory allocationAlejandro Lucero
If the function actually returns a null value, a null pointer dereference will occur. Coverity issue: 195013 Fixes: dd63df2bfff3 ("net/nfp: add NSP symbol resolution command") Signed-off-by: Alejandro Lucero <>
2017-11-10net/nfp: fix stats struct initial valueAlejandro Lucero
Not all struct fields will be written and random data could confuse readers. Coverity issue: 140755 Fixes: 92aa491b881e ("nfp: add statistics") Cc: Signed-off-by: Alejandro Lucero <>
2017-11-10drivers/net: fix number of segment storage typeIlya V. Matveychikov
Fixes: 97cb466d65c9 ("mbuf: use 2 bytes for port and nb segments") Cc: Signed-off-by: Ilya V. Matveychikov <> Reviewed-by: Ferruh Yigit <>
2017-11-10net/mlx4: fix rxq interrupt memory corruptionShahaf Shuler
intr_vec allocation size was wrong causing a memory corruption. Fixes: 0a2ae703192c ("net/mlx4: fix Rx interrupts management") Cc: Signed-off-by: Shahaf Shuler <> Acked-by: Adrien Mazarguil <>
2017-11-10net/mlx5: fix rxq interrupt memory corruptionShahaf Shuler
intr_vec allocation size was wrong causing a memory corruption. Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management") Cc: Signed-off-by: Shahaf Shuler <> Acked-by: Adrien Mazarguil <>