summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorMaxime Leroy <maxime.leroy@6wind.com>2013-09-02 17:07:55 +0200
committerThomas Monjalon <thomas.monjalon@6wind.com>2014-01-15 18:11:18 +0100
commit1035e8bd10a656f623475ad30e7e3d088f780fe1 (patch)
treef0a6d5f6f601b128740a142135f3b572b0dc9daa /lib
parent3f11491f4828d506a449c59fed535af4e43d6184 (diff)
downloaddpdk-1035e8bd10a656f623475ad30e7e3d088f780fe1.zip
dpdk-1035e8bd10a656f623475ad30e7e3d088f780fe1.tar.gz
dpdk-1035e8bd10a656f623475ad30e7e3d088f780fe1.tar.xz
igb/ixgbe: ETH_MQ_RX_NONE should disable RSS
As explained in rte_ethdev.h, ETH_MQ_RX_NONE allows to not choose RSS, DCB or VMDQ mode. But the igb/ixgbe code always silently select the RSS mode with ETH_MQ_RX_NONE. This patch fixes this incoherence between the API and the implementation. Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com> Acked-by: Ivan Boule <ivan.boule@6wind.com>
Diffstat (limited to 'lib')
-rw-r--r--lib/librte_pmd_e1000/igb_rxtx.c4
-rw-r--r--lib/librte_pmd_ixgbe/ixgbe_rxtx.c4
2 files changed, 4 insertions, 4 deletions
diff --git a/lib/librte_pmd_e1000/igb_rxtx.c b/lib/librte_pmd_e1000/igb_rxtx.c
index 38ed465..6b09339 100644
--- a/lib/librte_pmd_e1000/igb_rxtx.c
+++ b/lib/librte_pmd_e1000/igb_rxtx.c
@@ -1747,8 +1747,6 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev)
*/
if (dev->data->nb_rx_queues > 1)
switch (dev->data->dev_conf.rxmode.mq_mode) {
- case ETH_MQ_RX_NONE:
- /* if mq_mode not assign, we use rss mode.*/
case ETH_MQ_RX_RSS:
igb_rss_configure(dev);
break;
@@ -1756,6 +1754,8 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev)
/*Configure general VMDQ only RX parameters*/
igb_vmdq_rx_hw_configure(dev);
break;
+ case ETH_MQ_RX_NONE:
+ /* if mq_mode is none, disable rss mode.*/
default:
igb_rss_disable(dev);
break;
diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
index d0c8cbb..cabecdd 100644
--- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
+++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c
@@ -3217,8 +3217,6 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)
*/
if (dev->data->nb_rx_queues > 1)
switch (dev->data->dev_conf.rxmode.mq_mode) {
- case ETH_MQ_RX_NONE:
- /* if mq_mode not assign, we use rss mode.*/
case ETH_MQ_RX_RSS:
ixgbe_rss_configure(dev);
break;
@@ -3231,6 +3229,8 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)
ixgbe_vmdq_rx_hw_configure(dev);
break;
+ case ETH_MQ_RX_NONE:
+ /* if mq_mode is none, disable rss mode.*/
default: ixgbe_rss_disable(dev);
}
else