summaryrefslogtreecommitdiff
path: root/examples/fips_validation
diff options
context:
space:
mode:
authorChaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>2019-09-25 07:31:34 +0100
committerAkhil Goyal <akhil.goyal@nxp.com>2019-10-09 11:50:12 +0200
commit75b3dddf95ea0d5a1356115f748e1cc43de67886 (patch)
tree77cc6eee582c36af3964dc1836464f61efc11825 /examples/fips_validation
parente671f2041f5c13e6fecda7dbe421ae0940a8088b (diff)
downloaddpdk-75b3dddf95ea0d5a1356115f748e1cc43de67886.zip
dpdk-75b3dddf95ea0d5a1356115f748e1cc43de67886.tar.gz
dpdk-75b3dddf95ea0d5a1356115f748e1cc43de67886.tar.xz
examples/fips_validation: fix null dereferences
One issue caught by Coverity 343408 *deref_parm: Directly dereferencing parameter val->val. In writeback_tdes_hex_str(), tmp_val is initialised to null. tmp_val.val is updated only if keys are found. If keys are not found,it doesn't fails but continues to invoke writeback_hex_str(),where val->val is accessed without null check. The fix is to return the error, if keys are not found in writeback_tdes_hex_str(). Coverity issue: 343408 Fixes: 527cbf3d5e ("examples/fips_validation: support TDES parsing") Cc: stable@dpdk.org Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Diffstat (limited to 'examples/fips_validation')
-rw-r--r--examples/fips_validation/fips_validation_tdes.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/examples/fips_validation/fips_validation_tdes.c b/examples/fips_validation/fips_validation_tdes.c
index 15ee434..2b262c9 100644
--- a/examples/fips_validation/fips_validation_tdes.c
+++ b/examples/fips_validation/fips_validation_tdes.c
@@ -212,6 +212,8 @@ writeback_tdes_hex_str(const char *key, char *dst, struct fips_val *val)
tmp_val.val = val->val + 8;
else if (strstr(key, KEY3_STR))
tmp_val.val = val->val + 16;
+ else
+ return -EINVAL;
return writeback_hex_str(key, dst, &tmp_val);
}