summaryrefslogtreecommitdiff
path: root/drivers/net/atlantic/hw_atl/hw_atl_utils.c
diff options
context:
space:
mode:
authorIgor Russkikh <igor.russkikh@aquantia.com>2019-03-12 15:24:55 +0000
committerFerruh Yigit <ferruh.yigit@intel.com>2019-03-20 18:15:42 +0100
commit0b504bcfefc29fbafd9278603022093df401a85f (patch)
treef56f64577ae1bf7eca36183ea609663a539f02db /drivers/net/atlantic/hw_atl/hw_atl_utils.c
parent1da02f4ebe1ddfaf9adbe0fdf43288b20596b43f (diff)
downloaddpdk-0b504bcfefc29fbafd9278603022093df401a85f.zip
dpdk-0b504bcfefc29fbafd9278603022093df401a85f.tar.gz
dpdk-0b504bcfefc29fbafd9278603022093df401a85f.tar.xz
net/atlantic: remove extra checks for error codes
Found by Coverity scan. Checks are useless because at these code places err is always zero. Fixes: 86d36773bd42 ("net/atlantic: implement firmware operations") Cc: stable@dpdk.org Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Diffstat (limited to 'drivers/net/atlantic/hw_atl/hw_atl_utils.c')
-rw-r--r--drivers/net/atlantic/hw_atl/hw_atl_utils.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils.c b/drivers/net/atlantic/hw_atl/hw_atl_utils.c
index f11093a..13f02b9 100644
--- a/drivers/net/atlantic/hw_atl/hw_atl_utils.c
+++ b/drivers/net/atlantic/hw_atl/hw_atl_utils.c
@@ -462,8 +462,6 @@ int hw_atl_utils_fw_rpc_wait(struct aq_hw_s *self,
goto err_exit;
}
} while (sw.tid != fw.tid || 0xFFFFU == fw.len);
- if (err < 0)
- goto err_exit;
if (rpc) {
if (fw.len) {
@@ -875,8 +873,7 @@ static int aq_fw1x_set_wol(struct aq_hw_s *self, bool wol_enabled, u8 *mac)
}
err = hw_atl_utils_fw_rpc_call(self, rpc_size);
- if (err < 0)
- goto err_exit;
+
err_exit:
return err;
}