summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJulien Cretin <julien.cretin@trust-in-soft.com>2014-05-12 17:35:11 +0200
committerThomas Monjalon <thomas.monjalon@6wind.com>2014-05-14 11:22:11 +0200
commit5706de65334e11bae4847e9ace5e58b71d743f42 (patch)
treee218e422f69a948de1ecfd4c07547435a14cb8a6
parent6f8d4ded4affdfe051d0b8ea66f06dd71675451a (diff)
downloaddpdk-5706de65334e11bae4847e9ace5e58b71d743f42.zip
dpdk-5706de65334e11bae4847e9ace5e58b71d743f42.tar.gz
dpdk-5706de65334e11bae4847e9ace5e58b71d743f42.tar.xz
app/testpmd: fix incompatible sign for printf arguments
The socket_id member of struct rte_port is an unsigned int while the d conversion specifier of printf expects an int. The addr_bytes member of struct ether_addr is an array of uint8_t while the X conversion specifier of printf expects an unsigned int. Values of type uint8_t are promoted to type int when used in the ellipsis notation of a function. These minor bugs were found using TrustInSoft Analyzer. Signed-off-by: Julien Cretin <julien.cretin@trust-in-soft.com> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
-rw-r--r--app/test-pmd/config.c16
-rw-r--r--app/test-pmd/testpmd.c2
2 files changed, 9 insertions, 9 deletions
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 1feb133..134bf07 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -100,12 +100,12 @@ static void
print_ethaddr(const char *name, struct ether_addr *eth_addr)
{
printf("%s%02X:%02X:%02X:%02X:%02X:%02X", name,
- eth_addr->addr_bytes[0],
- eth_addr->addr_bytes[1],
- eth_addr->addr_bytes[2],
- eth_addr->addr_bytes[3],
- eth_addr->addr_bytes[4],
- eth_addr->addr_bytes[5]);
+ (unsigned int)eth_addr->addr_bytes[0],
+ (unsigned int)eth_addr->addr_bytes[1],
+ (unsigned int)eth_addr->addr_bytes[2],
+ (unsigned int)eth_addr->addr_bytes[3],
+ (unsigned int)eth_addr->addr_bytes[4],
+ (unsigned int)eth_addr->addr_bytes[5]);
}
void
@@ -256,7 +256,7 @@ port_infos_display(portid_t port_id)
printf("\n%s Infos for port %-2d %s\n",
info_border, port_id, info_border);
print_ethaddr("MAC address: ", &port->eth_addr);
- printf("\nConnect to socket: %d", port->socket_id);
+ printf("\nConnect to socket: %u", port->socket_id);
if (port_numa[port_id] != NUMA_NO_CONFIG) {
mp = mbuf_pool_find(port_numa[port_id]);
@@ -264,7 +264,7 @@ port_infos_display(portid_t port_id)
printf("\nmemory allocation on the socket: %d",
port_numa[port_id]);
} else
- printf("\nmemory allocation on the socket: %d",port->socket_id);
+ printf("\nmemory allocation on the socket: %u",port->socket_id);
printf("\nLink status: %s\n", (link.link_status) ? ("up") : ("down"));
printf("Link speed: %u Mbps\n", (unsigned) link.link_speed);
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 9c56914..55a5ea1 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -1250,7 +1250,7 @@ start_port(portid_t pid)
if (port->need_reconfig > 0) {
port->need_reconfig = 0;
- printf("Configuring Port %d (socket %d)\n", pi,
+ printf("Configuring Port %d (socket %u)\n", pi,
port->socket_id);
/* configure port */
diag = rte_eth_dev_configure(pi, nb_rxq, nb_txq,