summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlejandro Lucero <alejandro.lucero@netronome.com>2017-11-08 12:19:48 +0000
committerFerruh Yigit <ferruh.yigit@intel.com>2017-11-10 09:31:24 +0000
commitf5cba91b095d54e8d7fcea57e515b5b4453b02ba (patch)
tree79e75669c1b8aff70484dd208c597448b931c9fc
parenteb04bc1052e10188ac709658a5b794bdd31e9aa9 (diff)
downloaddpdk-f5cba91b095d54e8d7fcea57e515b5b4453b02ba.zip
dpdk-f5cba91b095d54e8d7fcea57e515b5b4453b02ba.tar.gz
dpdk-f5cba91b095d54e8d7fcea57e515b5b4453b02ba.tar.xz
net/nfp: fix checking function return value
The fstat function could return a value that indicates an error condition. If this is not checked, the error condition may not be handled correctly. Coverity issue: 195019 Fixes: f37d8a4b67b2 ("net/nfp: add NSP FW upload command") Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
-rw-r--r--drivers/net/nfp/nfp_nspu.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/net/nfp/nfp_nspu.c b/drivers/net/nfp/nfp_nspu.c
index 3c8cdad..39d14e6 100644
--- a/drivers/net/nfp/nfp_nspu.c
+++ b/drivers/net/nfp/nfp_nspu.c
@@ -341,7 +341,12 @@ nfp_fw_upload(nspu_desc_t *nspu_desc)
return -ENOENT;
}
- fstat(fw_f, &file_stat);
+ if (fstat(fw_f, &file_stat) < 0) {
+ RTE_LOG(INFO, PMD, "Firmware file %s/%s size is unknown",
+ DEFAULT_FW_PATH, DEFAULT_FW_FILENAME);
+ close(fw_f);
+ return -ENOENT;
+ }
fsize = file_stat.st_size;
RTE_LOG(DEBUG, PMD, "Firmware file with size: %" PRIu64 "\n",