|author||Yuanhan Liu <email@example.com>||2016-07-19 12:17:48 +0800|
|committer||Thomas Monjalon <firstname.lastname@example.org>||2016-07-22 19:58:10 +0200|
doc: note a pitfall on vhost reconnect feature
The vhost feature negotiation only happens at virtio reset stage, say when a virtio-net device is firstly initiated, or when DPDK virtio PMD initiates. That means, if vhost APP restarts after the negotiation and reconnects, the feature negotiation process will not be triggered again, meaning the info is lost. To make reconnect work, QEMU simply saves the negotiated features before the restart and restores it afterwards. Therefore, the vhost supported features must be exactly the same before and after the restart. For example, if TSO is disabled and then enabled, nothing will work and undefined issues might happen. Signed-off-by: Yuanhan Liu <email@example.com> Acked-by: John McNamara <firstname.lastname@example.org>
1 files changed, 6 insertions, 1 deletions
diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst
index 14d5e67..6b0c6b2 100644
@@ -189,7 +189,12 @@ vhost-user implementation has two options:
When the DPDK vhost-user application restarts, DPDK vhost-user will try to
connect to the server again. This is how the "reconnect" feature works.
- Note: the "reconnect" feature requires **QEMU v2.7** (or above).
+ .. Note::
+ * The "reconnect" feature requires **QEMU v2.7** (or above).
+ * The vhost supported features must be exactly the same before and
+ after the restart. For example, if TSO is disabled and then enabled,
+ nothing will work and issues undefined might happen.
No matter which mode is used, once a connection is established, DPDK
vhost-user will start receiving and processing vhost messages from QEMU.