diff options
author | Jonathan Ribas <jonathan.ribas@fraudbuster.mobi> | 2019-02-12 18:03:30 +0100 |
---|---|---|
committer | Jonathan Ribas <jonathan.ribas@fraudbuster.mobi> | 2019-02-12 18:06:26 +0100 |
commit | cba2796637e0cf635a4ca585135dc8cadc9c11ae (patch) | |
tree | 31078c3a60ea27607ad06c8a35edd32b55af1b33 | |
parent | c76a3e652b4198cc43fc7720dd3f3d46cf72ec53 (diff) | |
download | dpdk-burst-replay-cba2796637e0cf635a4ca585135dc8cadc9c11ae.zip dpdk-burst-replay-cba2796637e0cf635a4ca585135dc8cadc9c11ae.tar.gz dpdk-burst-replay-cba2796637e0cf635a4ca585135dc8cadc9c11ae.tar.xz |
Minor changes related to bug #203 discussion.
https://bugs.dpdk.org/show_bug.cgi?id=203
-rw-r--r-- | README.md | 2 | ||||
-rw-r--r-- | docs/src/readme.rst | 2 | ||||
-rw-r--r-- | src/main.c | 18 |
3 files changed, 13 insertions, 9 deletions
@@ -42,6 +42,8 @@ Example: * Be able to send dumps simultaneously on both numacores. * Split big pkts into multiple mbufs. * Add a Python module to facilitate scripting (something like what does scapy for tcpreplay sendpfast func). +* Manage systems with more than 2 numa cores. +* Use the maximum NICs capabilities (Tx queues/descriptors). ## BSD LICENCE diff --git a/docs/src/readme.rst b/docs/src/readme.rst index 043e80b..0f94d06 100644 --- a/docs/src/readme.rst +++ b/docs/src/readme.rst @@ -59,6 +59,8 @@ TODO * Be able to send dumps simultaneously on both numacores. * Split big pkts into multiple mbufs. * Add a Python module to facilitate scripting (something like what does scapy for tcpreplay sendpfast func). +* Manage systems with more than 2 numa cores. +* Use the maximum NICs capabilities (Tx queues/descriptors). BSD LICENCE ----------- @@ -16,15 +16,15 @@ void usage(void) { - puts("dpdk-replay [options] pcap_file port1[,portx...]\n" - "pcap_file: the file to send through the DPDK ports.\n" - "port1[,portx...] : specify the list of ports to be used (pci addresses).\n" + puts("dpdk-replay [OPTIONS] PCAP_FILE PORT1[,PORTX...]\n" + "PCAP_FILE: the file to send through the DPDK ports.\n" + "PORT1[,PORTX...] : specify the list of ports to be used (pci addresses).\n" "Options:\n" - "--numacore numacore : select the wanted numa core you want to use. Only\n" - " NICs on the selected numa core will be available (default: numa core 0).\n" - "--nbruns X : set the wanted number of replay (1 by default). Set to 0 to infinite mode.\n" + "--numacore <NUMA-CORE> : use cores from the desired NUMA. Only\n" + " NICs on the selected numa core will be available (default is 0).\n" + "--nbruns <1-N> : set the wanted number of replay (1 by default).\n" "--wait-enter: will wait until you press ENTER to start the replay (asked\n" - " once all the initialization are done)" + " once all the initialization are done)." /* TODO: */ /* "[--maxbitrate bitrate]|[--normalspeed] : bitrate not to be exceeded (default: no limit) in ko/s.\n" */ /* " specify --normalspeed to replay the trace with the good timings." */ @@ -103,7 +103,7 @@ int parse_options(const int ac, char** av, struct cmd_opts* opts) return (ENOENT); nc = atoi(av[i + 1]); - if (nc < 0 || nc > 127) + if (nc < 0 || nc > 2) return (ENOENT); opts->numacore = (char)nc; i++; @@ -117,7 +117,7 @@ int parse_options(const int ac, char** av, struct cmd_opts* opts) return (ENOENT); opts->nbruns = atoi(av[i + 1]); - if (opts->nbruns < 0) + if (opts->nbruns <= 0) return (EPROTO); i++; continue; |